デザインリニューアルのrelease用PR #341
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
=> Failed to build the preview
Error: Cannot find module 'ajv/dist/compile/codegen'
Require stack:
- ./node_modules/ajv-keywords/dist/definitions/typeof.js
- ./node_modules/ajv-keywords/dist/keywords/typeof.js
- ./node_modules/ajv-keywords/dist/keywords/index.js
- ./node_modules/ajv-keywords/dist/index.js
- ./node_modules/schema-utils/dist/validate.js
- ./node_modules/schema-utils/dist/index.js
- ./node_modules/webpack-dev-middleware/dist/index.js
- ./node_modules/@storybook/builder-webpack5/dist/index.js
- ./node_modules/@storybook/nextjs/dist/preset.js
- ./node_modules/@storybook/core/dist/common/index.cjs
- ./node_modules/@storybook/core/dist/telemetry/index.cjs
- ./node_modules/storybook/dist/generate.cjs
- ./node_modules/storybook/bin/index.cjs
at Module._resolveFilename (node:internal/modules/cjs/loader:1144:15)
at Module._resolveFilename (./node_modules/esbuild-register/dist/node.js:4794:36)
at <anonymous> (./node_modules/next/src/server/require-hook.ts:51:34)
at Module._load (node:internal/modules/cjs/loader:985:27)
at Module.require (node:internal/modules/cjs/loader:1235:19)
at Module.mod.require (./node_modules/next/src/server/require-hook.ts:70:26)
at require (node:internal/modules/helpers:176:18)
at Object.<anonymous> (./node_modules/ajv-keywords/src/definitions/typeof.ts:2:1)
at Module._compile (node:internal/modules/cjs/loader:1376:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
```
Next.js + Tailwind CSSで開発出来るようにProject構成を変更
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
共通利用するButtonComponentを実装
…menu HeaderComponentにログイン状態用のメニューを設置
…-test E2Eテスト実行環境とComponentのテストを追加
src/utils/gtm.ts 36:13 error Use a `type` instead of an `interface` ts/consistent-type-definitions 42:3 error Definition for rule '@typescript-eslint/strict-boolean-expressions' was not found @typescript-eslint/strict-boolean-expressions 51:3 error Definition for rule '@typescript-eslint/strict-boolean-expressions' was not found @typescript-eslint/strict-boolean-expressions 60:3 error Definition for rule '@typescript-eslint/strict-boolean-expressions' was not found @typescript-eslint/strict-boolean-expressions 69:3 error Definition for rule '@typescript-eslint/strict-boolean-expressions' was not found @typescript-eslint/strict-boolean-expressions 78:3 error Definition for rule '@typescript-eslint/strict-boolean-expressions' was not found @typescript-eslint/strict-boolean-expressions 87:3 error Definition for rule '@typescript-eslint/strict-boolean-expressions' was not found @typescript-eslint/strict-boolean-expressions 96:3 error Definition for rule '@typescript-eslint/strict-boolean-expressions' was not found @typescript-eslint/strict-boolean-expressions
src/utils/assertNever.ts 1:1 error Definition for rule '@typescript-eslint/no-unused-vars' was not found @typescript-eslint/no-unused-vars 2:29 error 'value' is defined but never used. Allowed unused args must match /^_/u unused-imports/no-unused-vars
/lgtm-cat-frontend/src/app/_components/Header.test.tsx 31:51 warning Use shorthand boolean attribute 'isLoggedIn' react/prefer-shorthand-boolean 42:51 warning Use shorthand boolean attribute 'isLoggedIn' react/prefer-shorthand-boolean /lgtm-cat-frontend/src/app/_components/HeaderLogo.tsx 21:41 warning Use shorthand boolean attribute 'aria-hidden' react/prefer-shorthand-boolean /lgtm-cat-frontend/src/app/_components/LoginButton.tsx 14:7 warning Use shorthand boolean attribute 'showGithubIcon' react/prefer-shorthand-boolean
…-packages ESLintの設定を @antfu/eslint-config を使った形に変更
…ader-component HeaderComponentのマージンの調整
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
nekochans/lgtm-cat#36
関連 URL
https://lgtm-cat-frontend-git-release-epic36design-ren-cc4825-nekochans.vercel.app/
このPRで対応すること / このPRで対応しないこと
nekochans/lgtm-cat#36 のreleaseに必要な実装を全て実施します。
（詳細は機能毎にPRを作成して対応）
Storybook の URL もしくはスクリーンショット
変更点概要
デザインリニューアル（2024年版）用のrelease用PRです。詳細は下記を参照。
レビュアーに重点的にチェックして欲しい点
各PRに記載
補足情報
各PRに記載