Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HeaderComponentにログイン状態用のメニューを設置 #350

Merged

Conversation

keitakn
Copy link
Member

@keitakn keitakn commented Oct 5, 2024

issueURL

#349

関連 URL

Headerは常時表示されるので全URLで利用される。

このPRで対応すること / このPRで対応しないこと

HeaderComponentにログイン時のmenuを追加します。

Storybook の URL もしくはスクリーンショット

https://622b6c5dc31e9e003a111eb5-hnijsfqstu.chromatic.com/?path=/story/app-components-header--logged-in-header-in-english

変更点概要

HeaderComponentにログイン状態用のメニューを設置

レビュアーに重点的にチェックして欲しい点

特になし

補足情報

特になし

@keitakn keitakn self-assigned this Oct 5, 2024
Copy link

vercel bot commented Oct 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lgtm-cat-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 3:19pm

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 118 lines in your changes missing coverage. Please review.

Project coverage is 9.62%. Comparing base (6dad764) to head (97c30f5).
Report is 9 commits behind head on release/epic36/design-renewal-2024.

Files with missing lines Patch % Lines
src/app/_components/Header.tsx 0.00% 34 Missing ⚠️
src/app/_components/HeaderI18n.ts 0.00% 30 Missing ⚠️
src/app/_components/icons/GithubIcon.stories.tsx 0.00% 19 Missing and 1 partial ⚠️
src/app/_components/Header.stories.tsx 0.00% 16 Missing ⚠️
src/app/_components/icons/GithubIcon.tsx 0.00% 12 Missing and 1 partial ⚠️
src/app/_components/IconButton.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                          @@
##           release/epic36/design-renewal-2024    #350      +/-   ##
=====================================================================
- Coverage                               10.13%   9.62%   -0.52%     
=====================================================================
  Files                                      70      72       +2     
  Lines                                    1776    1871      +95     
  Branches                                   94      96       +2     
=====================================================================
  Hits                                      180     180              
- Misses                                   1535    1628      +93     
- Partials                                   61      63       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keitakn keitakn marked this pull request as ready for review October 7, 2024 15:21
@keitakn keitakn merged commit 3008ecc into release/epic36/design-renewal-2024 Oct 7, 2024
7 of 9 checks passed
@keitakn keitakn deleted the feature/issue349/add-loggedin-menu branch October 7, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant