-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HeaderComponentにログイン状態用のメニューを設置 #350
Merged
keitakn
merged 8 commits into
release/epic36/design-renewal-2024
from
feature/issue349/add-loggedin-menu
Oct 7, 2024
Merged
HeaderComponentにログイン状態用のメニューを設置 #350
keitakn
merged 8 commits into
release/epic36/design-renewal-2024
from
feature/issue349/add-loggedin-menu
Oct 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/epic36/design-renewal-2024 #350 +/- ##
=====================================================================
- Coverage 10.13% 9.62% -0.52%
=====================================================================
Files 70 72 +2
Lines 1776 1871 +95
Branches 94 96 +2
=====================================================================
Hits 180 180
- Misses 1535 1628 +93
- Partials 61 63 +2 ☔ View full report in Codecov by Sentry. |
keitakn
merged commit Oct 7, 2024
3008ecc
into
release/epic36/design-renewal-2024
7 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#349
関連 URL
Headerは常時表示されるので全URLで利用される。
このPRで対応すること / このPRで対応しないこと
HeaderComponentにログイン時のmenuを追加します。
Storybook の URL もしくはスクリーンショット
https://622b6c5dc31e9e003a111eb5-hnijsfqstu.chromatic.com/?path=/story/app-components-header--logged-in-header-in-english
変更点概要
HeaderComponentにログイン状態用のメニューを設置
レビュアーに重点的にチェックして欲しい点
特になし
補足情報
特になし