-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache dockerhub images from linux for macOS #768
Conversation
An attempt to avoid hitting the dockerhub Pull Rate Limit.
Codecov Report
@@ Coverage Diff @@
## master #768 +/- ##
==========================================
+ Coverage 49.27% 53.92% +4.65%
==========================================
Files 23 23
Lines 2401 2674 +273
==========================================
+ Hits 1183 1442 +259
+ Misses 1090 1086 -4
- Partials 128 146 +18
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My plans are to escape DockerHub and move everything to other registries but this will suffice for now.
This comment has been minimized.
This comment has been minimized.
This PR doesn't need work, it only needs to be merged manually |
An attempt to avoid hitting the dockerhub Pull Rate Limit.
There is a small overhead due to caching (ca. +2 min, next run within 7 days only some seconds), but it might avoid rerunning the macOS job due to this error.
Restoreing the cache doesn't take much extra job execution time, because the test step is pulling less images from dockerhub.
This PR failed due to this limit #776.
It seems to be triggered by multiple PR's are opened within some days.
Needs more testing, if this solves the dockerhub limit problems or only delays the problem to happen less frequently.
Add new dockerhub images to
CACHED_DOCKER_IMAGES
and increment the cache key (CACHED_DOCKER_IMAGES_KEY
)What do you think?
I need ACT_OWNER: ${{ github.repository_owner }} and ACT_REPOSITORY: ${{ github.repository }} to have all tests green within my fork