Generic arrays results in ClassCastException, as the value is actually a Collection

[Ph3n1x]

Expected Behavior

The loaded entity should have (depending on the specified generic type) a

• byte[]
• int[]
• String[]
• etc.

Current Behavior

The loaded entity has an

• ArrayList (instead of byte[])
• java.util.Collections$UnmodifiableRandomAccessList (instead of int[])
• java.util.Collections$UnmodifiableRandomAccessList (instead of String[])

As soon as you call the getter for getting the array, a ClassCastException is raised, as an ArrayList and UnmodifiableRandomAccessList are not the requested arrays

Possible Solution

Check the generic type and do not simply save a List. As a workaround: do not use arrays as generic types, but Lists.

Steps to Reproduce (for bugs)

Here is the link to the very basic example: https://github.com/Ph3n1x/neo4j-sdn-ogm-issue-report-template/tree/master/issue-492

1. Execute the tests. All three (byte[], int[], String[]) will all fail, because of a ClassCastException. See also the CHECKME inside the testcase

Context

In my real world project, my base class is something like BaseField and I have many classes extending it, like BytesField extends BaseField<byte[]>, StringField extends BaseField<String> and so on.
When I try to access the stored value of my fields with some sort of arrays beeing the generic type T, I get the described ClassCastException

Your Environment

• OGM Version used: 3.1.0
• Java Version used: 1.8 and 1.9
• Neo4J Version used: 3.4.0
• Bolt Driver Version used (if applicable): 3.1.0
• Operating System and Version: Ubuntu 18.04
• Link to your project: https://github.com/Ph3n1x/neo4j-sdn-ogm-issue-report-template/tree/master/issue-492