Fix ClassCastExceptions due to wrong type detection in certain hierarchies. #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation fails in some scenarios. Including the full type tools seems overkill and as it stands, it has only tested with JDK 9 and still uses Unsafe. Rewriting GenericTools would look pretty similar for our needs.
michael-simons
force-pushed
the
issue/492
branch
from
be03c79 to
7ff449b
Compare
Take all declared fields of the hierarchy into consideration when building a FieldsInfo for concrete classes. Resolve type of generics fields in subtype. This change also includes the tests from the original bug report.
This bug is probably unrelated.
michael-simons
force-pushed
the
issue/492
branch
from
7ff449b to
7bbf631
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #492.
Please see the individual commit messages.
In short:
FieldInfo:FieldInfonow checks the class hierarchy of a the current class in question and adds the declared fields of the hierarchy when the fields are generically types fields. Thus, theFieldsInfoof the concrete class takes precedence over the base class. this was the root cause, the generic fields would resolve as Object and than the mapper writes collection "as is"Again, I can take of merging into master and 3.1 if I see green lights. The changes in
FieldsInfoandFieldInfoare actual very non-invasive.