Fix for #576: Change the way of how cleared relations get handled #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 2, 2019
|
Thanks a lot for this really valuable PR! As you should have noticed I have splittet the changes into to separate PRs and polished them a bit. I wanted to understand first what's really happening in the compile context, haven't touched that area since started to work on OGM. Feel free to chime in into the PR #581. |
|
I'm gonna close this in favour of the #581. |
michael-simons
added a commit
that referenced
this pull request
Nov 15, 2019
The identity map used the wrong map to look up the expected hash value when both a node and relationship with the same id have been loaded and a NPE happened when casting literal Null to long. This has been fixed by first selecting the correct hash. The error first appeared in the performance optimizations in #576, #577 and #579.
michael-simons
added a commit
that referenced
this pull request
Nov 15, 2019
The identity map used the wrong map to look up the expected hash value when both a node and relationship with the same id have been loaded and a NPE happened when casting literal Null to long. This has been fixed by first selecting the correct hash. The error first appeared in the performance optimizations in #576, #577 and #579.
michael-simons
added a commit
that referenced
this pull request
Nov 15, 2019
The identity map used the wrong map to look up the expected hash value when both a node and relationship with the same id have been loaded and a NPE happened when casting literal Null to long. This has been fixed by first selecting the correct hash. The error first appeared in the performance optimizations in #576, #577 and #579.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, within a loop, it was checked whether a mapping had already been deleted and if so this mapping was added directly to the list of deleted relationships. This resulted in different results depending on the order of the mappings to be deleted.
By dividing this logic into two parts, the problem could be solved.
Related Issue
This PR solves #576.
How Has This Been Tested?
Test is provided with this PR and described in #576.
Types of changes
Checklist: