GH-576 - Fix deletion of relationship with the same type between the same nodes. #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
michael-simons
force-pushed
the
issue/576
branch
from
18c4f90 to
9037c39
Compare
Andy2003
suggested changes
Jan 2, 2019
core/src/main/java/org/neo4j/ogm/cypher/compiler/CypherContext.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/neo4j/ogm/cypher/compiler/CypherContext.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/neo4j/ogm/cypher/compiler/CypherContext.java
Outdated
Show resolved
Hide resolved
meistermeier
reviewed
Jan 2, 2019
core/src/main/java/org/neo4j/ogm/cypher/compiler/CypherContext.java
Outdated
Show resolved
Hide resolved
michael-simons
force-pushed
the
issue/576
branch
from
4254958 to
677b027
Compare
… same nodes. Co-authored-by: Michael Simons <michael.simons@neo4j.com>
michael-simons
force-pushed
the
issue/576
branch
from
677b027 to
cd4d8ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the polished version of @Andy2003's PR #577. I didn't change his logic but only clarified what's happening in the compile context. I'd back also cherry-pick this one into 3.1 after having green lights.