Skip to content

Commit

Permalink
test: allow no vectored gets happening (#7939)
Browse files Browse the repository at this point in the history
when running the regress tests locally without any environment variables
we use on CI, `test_pageserver_compaction_smoke` fails with division by
zero. fix it temporarily by allowing no vectored read happening. to be
cleaned when vectored get validation gets removed and the default value
can be changed.

Cc: #7381
  • Loading branch information
koivunej authored Jun 3, 2024
1 parent db477c0 commit 34f450c
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion test_runner/regress/test_compaction.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,13 @@ def test_pageserver_compaction_smoke(neon_env_builder: NeonEnvBuilder):

vectored_sum = metrics.query_one("pageserver_layers_visited_per_vectored_read_global_sum")
vectored_count = metrics.query_one("pageserver_layers_visited_per_vectored_read_global_count")
vectored_average = vectored_sum.value / vectored_count.value
if vectored_count.value > 0:
assert vectored_sum.value > 0
vectored_average = vectored_sum.value / vectored_count.value
else:
# special case: running local tests with default legacy configuration
assert vectored_sum.value == 0
vectored_average = 0

log.info(f"{non_vectored_average=} {vectored_average=}")

Expand Down

1 comment on commit 34f450c

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3244 tests run: 3093 passed, 0 failed, 151 skipped (full report)


Flaky tests (1)

Postgres 16

  • test_timeline_deletion_with_files_stuck_in_upload_queue: debug

Code coverage* (full report)

  • functions: 31.4% (6532 of 20798 functions)
  • lines: 48.3% (50419 of 104319 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
34f450c at 2024-06-03T15:00:05.856Z :recycle:

Please sign in to comment.