-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coalesce non-vectored get with vectored code (use vectored get for single key gets) #7381
Closed
4 tasks done
Tracked by
#6296
Labels
Comments
jcsp
added
c/storage/pageserver
Component: storage: pageserver
a/tech_debt
Area: related to tech debt
labels
Apr 15, 2024
jcsp
changed the title
Coalesce non-vectored got with vectored code (use vectored get for single key gets)
Coalesce non-vectored get with vectored code (use vectored get for single key gets)
Apr 15, 2024
5 tasks
Last week:
This week:
|
Last week:
This week:
|
Last week:
This week:
|
Last week:
This week:
|
#7939 should be reverted when the default is changed. |
koivunej
added a commit
that referenced
this issue
Jun 3, 2024
when running the regress tests locally without any environment variables we use on CI, `test_pageserver_compaction_smoke` fails with division by zero. fix it temporarily by allowing no vectored read happening. to be cleaned when vectored get validation gets removed and the default value can be changed. Cc: #7381
Rollout was completed a few weeks ago. At this point, the non-vectored read path is no longer in use (apart from validation which will be removed by #8005) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Anticipate some performance work to make vectored get equally fast for single key case (e.g. #6932)
Ordered list of changes
The text was updated successfully, but these errors were encountered: