Skip to content

Commit

Permalink
stocon: bump number of concurrent reconciles per operation (#8179)
Browse files Browse the repository at this point in the history
## Problem
Background node operations take a long time for loaded nodes.

## Summary of changes
Increase number of concurrent reconciles an operation is allowed to
spawn.
This should make drain and fill operations faster and the new value is
still well below the total limit of concurrent reconciles.
  • Loading branch information
VladLazar authored Jun 27, 2024
1 parent 54a06de commit 89cf8df
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion storage_controller/src/background_node_operations.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use std::{borrow::Cow, fmt::Debug, fmt::Display};
use tokio_util::sync::CancellationToken;
use utils::id::NodeId;

pub(crate) const MAX_RECONCILES_PER_OPERATION: usize = 10;
pub(crate) const MAX_RECONCILES_PER_OPERATION: usize = 32;

#[derive(Copy, Clone)]
pub(crate) struct Drain {
Expand Down
2 changes: 1 addition & 1 deletion test_runner/regress/test_storage_controller.py
Original file line number Diff line number Diff line change
Expand Up @@ -1636,7 +1636,7 @@ def test_background_operation_cancellation(neon_env_builder: NeonEnvBuilder):
env = neon_env_builder.init_configs()
env.start()

tenant_count = 5
tenant_count = 10
shard_count_per_tenant = 8
tenant_ids = []

Expand Down

1 comment on commit 89cf8df

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3028 tests run: 2901 passed, 1 failed, 126 skipped (full report)


Failures on Postgres 14

  • test_pgbench_intensive_init_workload[neon_on-github-actions-selfhosted-1000]: release
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_pgbench_intensive_init_workload[neon_on-release-pg14-github-actions-selfhosted-1000]"
Flaky tests (1)

Postgres 14

  • test_location_conf_churn[3]: debug

Code coverage* (full report)

  • functions: 32.6% (6891 of 21118 functions)
  • lines: 50.0% (53922 of 107861 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
89cf8df at 2024-06-27T14:43:00.045Z :recycle:

Please sign in to comment.