Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stocon: bump number of concurrent reconciles per operation #8179

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

VladLazar
Copy link
Contributor

Problem

Background node operations take a long time for loaded nodes.

Summary of changes

Increase number of concurrent reconciles an operation is allowed to spawn.
This should make drain and fill operations faster and the new value is still well
below the total limit of concurrent reconciles.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

This should make drain and fill operations faster and is still
well below the total limit of concurrent reconciles.
@VladLazar VladLazar requested a review from a team as a code owner June 27, 2024 08:36
@VladLazar VladLazar requested a review from jcsp June 27, 2024 08:36
Copy link

github-actions bot commented Jun 27, 2024

2965 tests run: 2849 passed, 0 failed, 116 skipped (full report)


Flaky tests (3)

Postgres 15

  • test_pageserver_chaos[None]: release

Postgres 14

  • test_slow_secondary_downloads[False]: release
  • test_replication_start: release

Code coverage* (full report)

  • functions: 32.7% (6896 of 21118 functions)
  • lines: 50.0% (53926 of 107861 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
2ee37d4 at 2024-06-27T13:25:08.026Z :recycle:

@VladLazar VladLazar enabled auto-merge (squash) June 27, 2024 12:19
@VladLazar VladLazar merged commit 89cf8df into main Jun 27, 2024
63 of 64 checks passed
@VladLazar VladLazar deleted the vlad/storcon-bump-number-of-reconciles-per-op branch June 27, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants