Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix timeout value used in XLogWaitForReplayOf (#9937)
The previous value assumed usec precision, while the timeout used is in milliseconds, causing replica backends to wait for (potentially) many hours for WAL replay without the expected progress reports in logs. This fixes the issue. Reported-By: Alexander Lakhin <exclusion@gmail.com> ## Problem neondatabase/postgres#279 (comment) The timeout value was configured with the assumption the indicated value would be microseconds, where it's actually milliseconds. That causes the backend to wait for much longer (2h46m40s) before it emits the "I'm waiting for recovery" message. While we do have wait events configured on this, it's not great to have stuck backends without clear logs, so this fixes the timeout value in all our PostgreSQL branches. ## PG PRs * PG14: neondatabase/postgres#542 * PG15: neondatabase/postgres#543 * PG16: neondatabase/postgres#544 * PG17: neondatabase/postgres#545
- Loading branch information
973a8d2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7070 tests run: 6736 passed, 1 failed, 333 skipped (full report)
Failures on Postgres 16
test_sharded_ingest[github-actions-selfhosted-vanilla-1]
: release-x86-64Flaky tests (3)
Postgres 17
test_read_validation
: release-x86-64Postgres 15
test_sharding_split_smoke
: release-arm64test_pull_timeline[True]
: release-x86-64Code coverage* (full report)
functions
:30.3% (8182 of 27046 functions)
lines
:47.7% (64850 of 135976 lines)
* collected from Rust tests only
973a8d2 at 2024-11-29T20:56:39.757Z :recycle: