Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pageserver: compaction downloads layers without setting access time #7937

Closed
jcsp opened this issue Jun 3, 2024 · 0 comments · Fixed by #7962
Closed

pageserver: compaction downloads layers without setting access time #7937

jcsp opened this issue Jun 3, 2024 · 0 comments · Fixed by #7962
Assignees
@skyzh
Labels
c/storage/pageserver Component: storage: pageserver t/bug Issue Type: Bug

Comments

@jcsp
Copy link
Collaborator

jcsp commented Jun 3, 2024 •
edited
Loading

This causes eviction thashing, for layers which are repeatedly used by compaction: they'll be evicted sooner than they should be.

It's also interesting that the compaction code is downloading layers it doesn't really read: maybe it's just reading the index, or maybe it's really downloading something unnecessarily?

(Internal example: https://neondb.slack.com/archives/C033RQ5SPDH/p1717173240981649?thread_ts=1717173149.850249&cid=C033RQ5SPDH)
@jcsp jcsp added t/bug Issue Type: Bug c/storage/pageserver Component: storage: pageserver labels Jun 3, 2024
@skyzh skyzh mentioned this issue Jun 4, 2024
Merged
5 tasks
skyzh added a commit that referenced this issue Jun 6, 2024
@skyzh
fix(pageserver): skip metadata compaction is LSN is not accumulated e…
5d05013 
…nough (#7962)

close #7937

Only trigger metadata image layer creation if enough delta layers are
accumulated.

Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skyzh skyzh

Labels
c/storage/pageserver Component: storage: pageserver t/bug Issue Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(pageserver): skip metadata compaction if LSN is not accumulated enough neondatabase/neon
2 participants
@jcsp @skyzh