Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageserver): skip metadata compaction if LSN is not accumulated enough #7962

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jun 4, 2024

Problem

close #7937

Summary of changes

Only trigger metadata image layer creation if enough delta layers are accumulated.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh requested a review from a team as a code owner June 4, 2024 19:57
@skyzh skyzh requested a review from petuhovskiy June 4, 2024 19:57
Copy link

github-actions bot commented Jun 4, 2024

3204 tests run: 3065 passed, 0 failed, 139 skipped (full report)


Flaky tests (3)

Postgres 16

  • test_pageserver_restarts_under_worload: release

Postgres 15

  • test_pageserver_restarts_under_worload: release

Postgres 14

  • test_sharding_split_compaction[compact-shard-ancestors-localonly]: debug

Code coverage* (full report)

  • functions: 31.6% (6600 of 20917 functions)
  • lines: 48.5% (51061 of 105214 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
d3e4f82 at 2024-06-06T16:04:28.317Z :recycle:

@skyzh skyzh changed the title fix(pageserver): update access stats for compaction fix(pageserver): reduce the frequency of metadata compaction + pin metadata layers Jun 5, 2024
@skyzh skyzh force-pushed the skyzh/compaction-update-access-behavior branch from 9ba294a to c7ca81d Compare June 5, 2024 17:53
@skyzh skyzh requested a review from koivunej June 5, 2024 17:53
…nough

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/compaction-update-access-behavior branch from c7ca81d to d3e4f82 Compare June 5, 2024 18:07
@skyzh skyzh changed the title fix(pageserver): reduce the frequency of metadata compaction + pin metadata layers fix(pageserver): skip metadata compaction is LSN is not accumulated enough Jun 5, 2024
@skyzh
Copy link
Member Author

skyzh commented Jun 5, 2024

ready for review again :)

@skyzh skyzh merged commit 5d05013 into main Jun 6, 2024
64 checks passed
@skyzh skyzh deleted the skyzh/compaction-update-access-behavior branch June 6, 2024 15:34
@skyzh skyzh changed the title fix(pageserver): skip metadata compaction is LSN is not accumulated enough fix(pageserver): skip metadata compaction if LSN is not accumulated enough Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pageserver: compaction downloads layers without setting access time
2 participants