Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test custom vm-builder version in preparation for monitor #4643

Closed
wants to merge 5 commits into from

Conversation

fprasx
Copy link
Contributor

@fprasx fprasx commented Jul 5, 2023

Problem

Sourcing a custom vm-builder version that supports the monitor. This is part of a greater change that will move upscaling/downscaling functionality from the vm-informant to compute_ctl.
Related to neondatabase/autoscaling#362

Eventually, this change should be reverted once autoscaling/main's version of vm-builder supports the monitor - a change currently included in neondatabase/autoscaling#362.

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@fprasx fprasx changed the title change source of vm-builder binary move monitor functionality into compute_ctl Jul 5, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

1016 tests run: 973 passed, 0 failed, 43 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_remote_storage_upload_queue_retries[local_fs]: release
The comment gets automatically updated with the latest test results
62c26e6 at 2023-07-06T17:54:05.207Z :recycle:

@fprasx fprasx requested a review from sharnoff July 6, 2023 17:37
@fprasx fprasx changed the title move monitor functionality into compute_ctl test custom vm-builder version in preparation for monitor Jul 6, 2023
@fprasx
Copy link
Contributor Author

fprasx commented Aug 16, 2023

Closing as superseded by neondatabase/autoscaling#477

@fprasx fprasx closed this Aug 16, 2023
@fprasx fprasx deleted the fprasx/use-monitor-image branch August 16, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant