vm-builder: add flag to enable informant/monitor at VM startup and remove cgexec #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default neither binary is started up.
sharnoff
reviewed
Aug 16, 2023
Makefile
Outdated
| @@ -196,7 +196,7 @@ docker-build-scheduler: ## Build docker image for (autoscaling) scheduler | |||
|
|
|||
| .PHONY: docker-build-examples | |||
| docker-build-examples: vm-informant bin/vm-builder ## Build docker images for testing VMs | |||
| ./bin/vm-builder -src postgres:15-bullseye -dst $(E2E_TESTS_VM_IMG) | |||
| ./bin/vm-builder -src postgres:15-bullseye -dst $(E2E_TESTS_VM_IMG) -enable-informant | |||
There was a problem hiding this comment.
Yup, just realized this. Am testing locally as it should be a little faster.
fprasx
changed the title
sharnoff
approved these changes
Aug 16, 2023
This was referenced Aug 16, 2023
fprasx
added a commit
to neondatabase/neon
that referenced
this pull request
Aug 18, 2023
A very slight change that allows us to configure the UID of the neon-postgres cgroup owner. We start postgres in this cgroup so we can scale it with the cgroups v2 api. Currently, the control plane overwrites the entrypoint set by `vm-builder`, so `compute_ctl` (and thus postgres), is not started in the neon-postgres cgroup. Having `compute_ctl` start postgres in the cgroup should fix this. However, at the moment appears like it does not have the correct permissions. Configuring the neon-postgres UID to `postgres` (which is the UID `compute_ctl` runs under) should hopefully fix this. See #4920 - the PR to modify `compute_ctl` to start postgres in the cgorup. See: neondatabase/autoscaling#480, neondatabase/autoscaling#477. Both these PR's are part of an effort to increase `vm-builder`'s configurability and allow us to adjust it as we integrate in the monitor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables more flexibility rolling out the monitor. We can keep using the monitor during
e2etests, while not enabling it for release builds.This PR also removes cgexec. This functionality will be delegated to
compute_ctl.