bump VM_BUILDER_VERSION to v0.16.2
#5031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A very slight change that allows us to configure the UID of the neon-postgres cgroup. This will possibly unlock neon/#4920, having `compute_ctl` start postgres in a cgroup instead of `vm-builder`.
This change is new to vm-builder v0.16.x. We'll remove these flags after the monitor is started by compute-ctl and in later release of vm-builder that include autoscaling #442, which allows the agent to communicate directly with the monitor
fprasx
force-pushed
the
fprasx/bump-vm-builder-version
branch
from
0be29fe to
65d6d42
Compare
sharnoff
reviewed
Aug 17, 2023
There was a problem hiding this comment.
Would be good to link relevant autoscaling repo PRs to help answer immediate questions (i.e. "why do we need the new args?" and "what's this UID business?"), but otherwise looks good
Also NB: if you just write #442 in a commit message, it'll link to this repo. To link to another repo, you can write neondatabase/autoscaling#442 (I think)
sharnoff
approved these changes
Aug 17, 2023
1612 tests run: 1537 passed, 0 failed, 75 skipped (full report)The comment gets automatically updated with the latest test results
76c5f95 at 2023-08-18T16:47:44.964Z :recycle: |
sharnoff
reviewed
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very slight change that allows us to configure the UID of the neon-postgres cgroup owner. We start postgres in this cgroup so we can scale it with the cgroups v2 api. Currently, the control plane overwrites the entrypoint set by
vm-builder, socompute_ctl(and thus postgres), is not started in the neon-postgres cgroup. Havingcompute_ctlstart postgres in the cgroup should fix this. However, at the moment appears like it does not have the correct permissions. Configuring the neon-postgres UID topostgres(which is the UIDcompute_ctlruns under) should hopefully fix this.See #4920 - the PR to modify
compute_ctlto start postgres in the cgorup.See: neondatabase/autoscaling#480, neondatabase/autoscaling#477. Both these PR's are part of an effort to increase
vm-builder's configurability and allow us to adjust it as we integrate in the monitor.