refactor(virtual_file): take owned buffer in VirtualFile::write_all #6664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can probably get rid of the entire trait, but, that's for another time.
…uilder-refactor' into problame/integrate-tokio-epoll-uring/write-path/simplify-write-at-api
This reverts commit b5a00b0.
…ath/refactor-blob-writer
…ath/refactor-blob-writer
…r-blob-writer' into problame/integrate-tokio-epoll-uring/write-path/refactor-virtual-file
2430 tests run: 2319 passed, 0 failed, 111 skipped (full report)Flaky tests (3)Postgres 16
Postgres 15
Postgres 14
Code coverage (full report)
The comment gets automatically updated with the latest test results
8998178 at 2024-02-12T16:14:35.121Z :recycle: |
…ath/refactor-blob-writer
…r-blob-writer' into problame/integrate-tokio-epoll-uring/write-path/virtual-file-write-all
…kio-epoll-uring/write-path/refactor-blob-writer
…r-blob-writer' into problame/integrate-tokio-epoll-uring/write-path/virtual-file-write-all
|
Will rebase once the preceding PR #6660 has merged. |
Base automatically changed from
problame/integrate-tokio-epoll-uring/write-path/refactor-blob-writer
to
main
February 12, 2024 14:58
…ath/virtual-file-write-all
arpad-m
requested changes
Feb 12, 2024
VladLazar
reviewed
Feb 13, 2024
arpad-m
approved these changes
Feb 13, 2024
VladLazar
approved these changes
Feb 13, 2024
problame
deleted the
problame/integrate-tokio-epoll-uring/write-path/virtual-file-write-all
branch
problame
added a commit
that referenced
this pull request
Feb 14, 2024
context: #6663 Building atop #6664, this PR switches `write_all_at` to take owned buffers. The main challenge here is the `EphemeralFile::mutable_tail`, for which I'm picking the ugly solution of an `Option` that is `None` while the IO is in flight. After this, we will be able to switch `write_at` to take owned buffers and call tokio-epoll-uring's `write` function with that owned buffer. That'll be done in #6378.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building atop #6660 , this PR converts VirtualFile::write_all to used owned buffers.
Part of #6663