refactor(virtual_file) make write_all_at take owned buffers #6673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can probably get rid of the entire trait, but, that's for another time.
…uilder-refactor' into problame/integrate-tokio-epoll-uring/write-path/simplify-write-at-api
This reverts commit b5a00b0.
…ath/refactor-blob-writer
…ath/refactor-blob-writer
…r-blob-writer' into problame/integrate-tokio-epoll-uring/write-path/refactor-virtual-file
…ath/refactor-blob-writer
…r-blob-writer' into problame/integrate-tokio-epoll-uring/write-path/virtual-file-write-all
…kio-epoll-uring/write-path/refactor-blob-writer
…r-blob-writer' into problame/integrate-tokio-epoll-uring/write-path/virtual-file-write-all
2436 tests run: 2318 passed, 0 failed, 118 skipped (full report)Code coverage (full report)
The comment gets automatically updated with the latest test results
6a55ac7 at 2024-02-14T14:48:40.261Z :recycle: |
…ath/virtual-file-write-all
…-file-write-all' into problame/integrate-tokio-epoll-uring/write-path/virtual-file-write-all-at
Base automatically changed from
problame/integrate-tokio-epoll-uring/write-path/virtual-file-write-all
to
main
February 13, 2024 17:46
…ath/virtual-file-write-all-at
…ath/virtual-file-write-all-at
VladLazar
approved these changes
Feb 14, 2024
arpad-m
approved these changes
Feb 14, 2024
problame
deleted the
problame/integrate-tokio-epoll-uring/write-path/virtual-file-write-all-at
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: #6663
Building atop #6664, this PR switches
write_all_atto take owned buffers.The main challenge here is the
EphemeralFile::mutable_tail, for which I'm picking the ugly solution of anOptionthat isNonewhile the IO is in flight.After this, we will be able to switch
write_atto take owned buffers and call tokio-epoll-uring'swritefunction with that owned buffer. That'll be done in #6378.