Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: switch on new-style local layer paths #7660

Merged
merged 1 commit into from
May 14, 2024

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented May 8, 2024

We recently added support for local layer paths that contain a generation number:

Now that we've cut a release that includes those changes, we can proceed to enable writing the new format without breaking forward compatibility.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added c/storage/pageserver Component: storage: pageserver a/tech_debt Area: related to tech debt labels May 8, 2024
Copy link

github-actions bot commented May 8, 2024

3060 tests run: 2933 passed, 0 failed, 127 skipped (full report)


Code coverage* (full report)

  • functions: 31.4% (6332 of 20168 functions)
  • lines: 47.3% (47822 of 101105 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
e36a30d at 2024-05-13T17:21:49.068Z :recycle:

@jcsp jcsp changed the title [DNM] pageserver: switch on new-style local layer paths pageserver: switch on new-style local layer paths May 13, 2024
@jcsp jcsp force-pushed the jcsp/issue-7504-local-paths-pt3 branch from 9698c97 to e36a30d Compare May 13, 2024 16:37
@jcsp jcsp requested a review from problame May 13, 2024 16:37
@jcsp jcsp marked this pull request as ready for review May 13, 2024 16:37
@jcsp jcsp requested a review from a team as a code owner May 13, 2024 16:37
@jcsp jcsp merged commit df0f1e3 into main May 14, 2024
54 of 55 checks passed
@jcsp jcsp deleted the jcsp/issue-7504-local-paths-pt3 branch May 14, 2024 08:37
a-masterov pushed a commit that referenced this pull request May 20, 2024
We recently added support for local layer paths that contain a
generation number:
- #7609
- #7640

Now that we've cut a
[release](#7735) that includes
those changes, we can proceed to enable writing the new format without
breaking forward compatibility.
skyzh added a commit that referenced this pull request Jun 24, 2024
We now have a `vX` number in the file name, i.e.,
`000000067F0000000400000B150100000000-000000067F0000000400000D350100000000__00000000014B7AC8-v1-00000001`

The related pull request for new-style path was merged a month ago
#7660

## Summary of changes

Fixed the draw timeline dir command to handle it.

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
conradludgate pushed a commit that referenced this pull request Jun 27, 2024
We now have a `vX` number in the file name, i.e.,
`000000067F0000000400000B150100000000-000000067F0000000400000D350100000000__00000000014B7AC8-v1-00000001`

The related pull request for new-style path was merged a month ago
#7660

## Summary of changes

Fixed the draw timeline dir command to handle it.

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants