Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageserver): handle version number in draw timeline #8102

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jun 18, 2024

Problem

We now have a vX number in the file name, i.e., 000000067F0000000400000B150100000000-000000067F0000000400000D350100000000__00000000014B7AC8-v1-00000001

The related pull request for new-style path was merged a month ago #7660

Summary of changes

Fixed the draw timeline dir command to handle it.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh requested a review from a team as a code owner June 18, 2024 18:33
@skyzh skyzh requested review from arpad-m and jcsp June 18, 2024 18:33
Copy link

github-actions bot commented Jun 18, 2024

2916 tests run: 2799 passed, 0 failed, 117 skipped (full report)


Flaky tests (1)

Postgres 14

Code coverage* (full report)

  • functions: 32.5% (6875 of 21131 functions)
  • lines: 50.0% (53384 of 106774 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
39bb15d at 2024-06-24T15:38:07.838Z :recycle:

Copy link
Member

@arpad-m arpad-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally there'd be some tests, but as there is no tests right now it's fine to merge as is.

skyzh added 2 commits June 24, 2024 10:42
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/fix-layer-map-draw branch from 1c948c0 to 39bb15d Compare June 24, 2024 14:46
@skyzh skyzh enabled auto-merge (squash) June 24, 2024 14:52
@skyzh skyzh merged commit d8ffe66 into main Jun 24, 2024
53 checks passed
@skyzh skyzh deleted the skyzh/fix-layer-map-draw branch June 24, 2024 15:31
conradludgate pushed a commit that referenced this pull request Jun 27, 2024
We now have a `vX` number in the file name, i.e.,
`000000067F0000000400000B150100000000-000000067F0000000400000D350100000000__00000000014B7AC8-v1-00000001`

The related pull request for new-style path was merged a month ago
#7660

## Summary of changes

Fixed the draw timeline dir command to handle it.

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants