Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add handling unsupported nans in stringifying_unsupported #1543

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

asledz
Copy link
Contributor

@asledz asledz commented Oct 23, 2023

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

@asledz asledz force-pushed the as/stringify_unsupported branch from 0d5e99c to 1a3b7b8 Compare October 23, 2023 23:28
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/neptune/common/warnings.py 96.87% <100.00%> (+0.20%) ⬆️
src/neptune/internal/types/stringify_value.py 86.20% <100.00%> (+5.25%) ⬆️

... and 56 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@asledz asledz marked this pull request as ready for review October 23, 2023 23:40
normandy7
normandy7 previously approved these changes Oct 24, 2023
@asledz asledz merged commit 2665902 into master Oct 24, 2023
4 checks passed
@asledz asledz deleted the as/stringify_unsupported branch October 24, 2023 13:30
@antoinebrl
Copy link

Hello, I'm wondering how the system reacts when the logging a float series that contains NaN and inf.

run["value"] = 0.1
run["value"] = np.nan
run["value"] = 1

@normandy7
Copy link
Collaborator

Hello, I'm wondering how the system reacts when the logging a float series that contains NaN and inf.

run["value"] = 0.1
run["value"] = np.nan
run["value"] = 1

Hey @antoinebrl! Neptune will skip unsupported values when logging a series (see related docs).

Sidenote: In your snippet, each new value would overwrite the one previously assigned to that field. Use the append() method to create a series:

run["series"].append(value)

For more, see Logging series of values or files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants