Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: eliminate chainstore lifecycle #3733

Merged
merged 1 commit into from
Dec 6, 2022
Merged

refactor: eliminate chainstore lifecycle #3733

merged 1 commit into from
Dec 6, 2022

Conversation

zhangsoledad
Copy link
Member

@zhangsoledad zhangsoledad commented Dec 2, 2022 •
edited
Loading

What is changed and how it works?

The new version of rocksdb supports transaction get_pinned, which can be used to eliminate the lifecycle on ChainStore, and also brings some fixes and performance improvements

nervosnetwork/rust-rocksdb#43

Check List

Tests

  • Unit test
  • Integration test

Release note 

Title Only: Include only the PR title in the release note.

@zhangsoledad zhangsoledad requested a review from a team as a code owner December 2, 2022 02:59
@zhangsoledad zhangsoledad requested review from quake and removed request for a team December 2, 2022 02:59
@zhangsoledad
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 6, 2022

Build succeeded:

@bors bors bot merged commit c30b5c4 into nervosnetwork:develop Dec 6, 2022
@doitian doitian mentioned this pull request Jan 12, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driftluo driftluo driftluo approved these changes

@quake quake Awaiting requested review from quake quake is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangsoledad @driftluo