-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump rocksdb to v7.7.3 #43
Conversation
0e55f98
to
c65775e
Compare
Fixes Compaction pending bytes calculation amplification issue that caused write stall, as discussed in: facebook/rocksdb#9423 |
Added a benchmark on transaction read uncommitted key and compared several versions7.3.1 7.5.3 transaction/transaction GetPinned/10000 7.7.3 transaction/transaction Get/10000 transaction/transaction GetPinned/10000 transaction get_pinned has some improvement in scenarios with larger values |
Also compared with rocksdb's built-in bench_tool ./db_bench --benchmarks="fillseq,overwrite,fill100K,readrandom,deleterandom,readwhilewriting,readrandomwriterandom,seekrandom,seekrandomwhilewriting,newiterator,randomtransaction,fillseekseq" 7.3.1
fillseq : 1.905 micros/op 524969 ops/sec 1.905 seconds 1000000 operations; 58.1 MB/s
overwrite : 3.144 micros/op 318045 ops/sec 3.144 seconds 1000000 operations; 35.2 MB/s
fill100K : 462.245 micros/op 2163 ops/sec 462.245 seconds 1000000 operations; 206.3 MB/s (1000 ops)
readrandom : 0.483 micros/op 2072195 ops/sec 0.483 seconds 1000000 operations; 202.4 MB/s (1024 of 1000000 found)
deleterandom : 3.151 micros/op 317385 ops/sec 3.151 seconds 1000000 operations;
readwhilewriting : 1.763 micros/op 567089 ops/sec 1.763 seconds 1000000 operations; 26.8 MB/s (185526 of 1000000 found)
readrandomwriterandom : 5.732 micros/op 174448 ops/sec 5.732 seconds 1000000 operations; ( reads:900000 writes:100000 total:1000000 found:384754)
seekrandom : 7.795 micros/op 128289 ops/sec 7.795 seconds 1000000 operations; (455638 of 1000000 found)
seekrandomwhilewriting : 15.864 micros/op 63037 ops/sec 15.864 seconds 1000000 operations; (838183 of 1000000 found)
newiterator : 0.988 micros/op 1012307 ops/sec 0.988 seconds 1000000 operations;
randomtransaction : 18.218 micros/op 54892 ops/sec 18.218 seconds 1000000 operations; 1.3 MB/s ( batches:1000000 )
fillseekseq : 3.553 micros/op 281449 ops/sec 7.106 seconds 2000000 operations;
Little difference, with an improvement in concurrent scenarios |
3733: refactor: eliminate chainstore lifecycle r=zhangsoledad a=zhangsoledad <!-- Thank you for contributing to nervosnetwork/ckb! If you haven't already, please read [CONTRIBUTING](https://github.com/nervosnetwork/ckb/blob/develop/CONTRIBUTING.md) document. If you're unsure about anything, just ask; somebody should be along to answer within a day or two. PR Title Format: 1. module [, module2, module3]: what's changed 2. *: what's changed --> ### What is changed and how it works? The new version of rocksdb supports transaction get_pinned, which can be used to eliminate the lifecycle on `ChainStore`, and also brings some fixes and performance improvements nervosnetwork/rust-rocksdb#43 ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - Unit test - Integration test ### Release note <!-- Choose from None, Title Only and Note. Bugfixes or new features need a release note. --> ```release-note Title Only: Include only the PR title in the release note. ``` Co-authored-by: zhangsoledad <787953403@qq.com>
No description provided.