IndexerService should use is_cancelled() to check if ckb received Ctrl-C signal
#4348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quake
approved these changes
Feb 9, 2024
EthanYuan
approved these changes
Feb 9, 2024
Closed
15168316096
reviewed
Mar 20, 2024
| }, | ||
| else => {}, | ||
| if stop.is_cancelled() { | ||
| info!("Indexer received exit signal, cancel new_block_watcher task, exit now"); |
There was a problem hiding this comment.
if use rich-indexer,this content need update? auto get indexer type which is using
There was a problem hiding this comment.
Not needed. The version of CKB that includes rich-indexer has been refactored, and this check is moved to the module indexer-sync, which is common to both indexer and rich-indexer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…trl-c signal
What problem does this PR solve?
Problem Summary:
In #4345, the
tokio::select!will stuck forever if ckb doesn't received ctrl-C signal. Should usestop.is_canceled().What's Changed:
Related changes
stop.is_canceled()to check if ckb has received exit signal.Check List
Tests
Side effects
Release note