Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mongoose to v8 #1937

Closed
1 task done
timonmasberg opened this issue Nov 5, 2023 · 2 comments · Fixed by #1940
Closed
1 task done

Update mongoose to v8 #1937

timonmasberg opened this issue Nov 5, 2023 · 2 comments · Fixed by #1940
Labels

Comments

@timonmasberg
Copy link

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

Mongoose version 8 was released, this package currently only supports v6 and v7.

Describe the solution you'd like

Bump mongoose peer dependency to allow v8.

Teachability, documentation, adoption, migration strategy

Changelog with breaking changes from v7 to v8: https://github.com/Automattic/mongoose/blob/master/CHANGELOG.md

What is the motivation / use case for changing the behavior?

To ensure that we are able to use the latest features and performance upgrades.

@md-redwan-hossain
Copy link

+1 when I updated to moongoose 8, these error are thrown.

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: hms-nestjs@0.0.1
npm WARN Found: mongoose@7.6.4
npm WARN node_modules/mongoose
npm WARN mongoose@"^8.0.0" from the root project
npm WARN 2 more (@nestjs/mongoose, @nestjs/terminus)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer mongoose@"^6.0.2 || ^7.0.0" from @nestjs/mongoose@10.0.1
npm WARN node_modules/@nestjs/mongoose
npm WARN @nestjs/mongoose@"^10.0.1" from the root project
npm WARN 1 more (@nestjs/terminus)
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: hms-nestjs@0.0.1
npm WARN Found: mongoose@7.6.4
npm WARN node_modules/mongoose
npm WARN mongoose@"^8.0.0" from the root project
npm WARN 2 more (@nestjs/mongoose, @nestjs/terminus)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer mongoose@"^6.0.2 || ^7.0.0" from @nestjs/mongoose@10.0.1
npm WARN node_modules/@nestjs/mongoose
npm WARN @nestjs/mongoose@"^10.0.1" from the root project
npm WARN 1 more (@nestjs/terminus)

orgads added a commit to orgads/nestjs-mongoose that referenced this issue Nov 7, 2023
All the tests pass successfully with mongoose 8.

Fixes nestjs#1937.
orgads added a commit to orgads/nestjs-mongoose that referenced this issue Nov 7, 2023
All the tests pass successfully with mongoose 8.

Fixes nestjs#1937.
@kamilmysliwiec
Copy link
Member

#1940

@nestjs nestjs locked and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants