Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update peer mongoose to include also v8 #1940

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Nov 7, 2023

All the tests pass successfully with mongoose 8.

Fixes #1937.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Peer dependencies allows only v6 and v7 of mongoose, while v8 was recently released, and the tests pass.

Issue Number: #1937.

What is the new behavior?

Allow also v8, without changing the direct dependency.

Does this PR introduce a breaking change?

  • Yes
  • No

@kamilmysliwiec kamilmysliwiec mentioned this pull request Nov 8, 2023
1 task
@kamilmysliwiec kamilmysliwiec merged commit 19d4c15 into nestjs:master Nov 8, 2023
1 check passed
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update mongoose to v8
2 participants