Merge pull request #12905 from micalevisk/feat/verbose-unknown-module…

…-errormsg feat(core): display module's name on `.select(module)` errors
nestjs · Dec 18, 2023 · a1780ff · a1780ff
2 parents 91cedae + 204971c
commit a1780ff
Show file tree

Hide file tree

Showing 7 changed files with 25 additions and 19 deletions.
diff --git a/packages/common/decorators/core/controller.decorator.ts b/packages/common/decorators/core/controller.decorator.ts
@@ -158,15 +158,15 @@ export function Controller(
   )
     ? [defaultPath, undefined, undefined, undefined]
     : isString(prefixOrOptions) || Array.isArray(prefixOrOptions)
-    ? [prefixOrOptions, undefined, undefined, undefined]
-    : [
-        prefixOrOptions.path || defaultPath,
-        prefixOrOptions.host,
-        { scope: prefixOrOptions.scope, durable: prefixOrOptions.durable },
-        Array.isArray(prefixOrOptions.version)
-          ? Array.from(new Set(prefixOrOptions.version))
-          : prefixOrOptions.version,
-      ];
+      ? [prefixOrOptions, undefined, undefined, undefined]
+      : [
+          prefixOrOptions.path || defaultPath,
+          prefixOrOptions.host,
+          { scope: prefixOrOptions.scope, durable: prefixOrOptions.durable },
+          Array.isArray(prefixOrOptions.version)
+            ? Array.from(new Set(prefixOrOptions.version))
+            : prefixOrOptions.version,
+        ];
 
   return (target: object) => {
     Reflect.defineMetadata(CONTROLLER_WATERMARK, true, target);

diff --git a/packages/core/errors/exceptions/unknown-module.exception.ts b/packages/core/errors/exceptions/unknown-module.exception.ts
@@ -1,9 +1,11 @@
 import { RuntimeException } from './runtime.exception';
 
 export class UnknownModuleException extends RuntimeException {
-  constructor() {
+  constructor(moduleName?: string) {
     super(
-      'Nest could not select the given module (it does not exist in current context)',
+      `Nest could not select the given module (${
+        moduleName ? `"${moduleName}"` : 'it'
+      } does not exist in current context).`,
     );
   }
 }
diff --git a/packages/core/nest-application-context.ts b/packages/core/nest-application-context.ts
@@ -99,7 +99,7 @@ export class NestApplicationContext<
 
     const selectedModule = modulesContainer.get(token);
     if (!selectedModule) {
-      throw new UnknownModuleException();
+      throw new UnknownModuleException(type.name);
     }
     return new NestApplicationContext(
       this.container,

diff --git a/packages/core/nest-factory.ts b/packages/core/nest-factory.ts
@@ -326,8 +326,8 @@ export class NestFactoryStatic {
           return result instanceof Promise
             ? result.then(mapToProxy)
             : result instanceof NestApplication
-            ? proxy
-            : result;
+              ? proxy
+              : result;
         };
 
         if (!(prop in receiver) && prop in adapter) {

diff --git a/packages/core/router/router-response-controller.ts b/packages/core/router/router-response-controller.ts
@@ -48,8 +48,8 @@ export class RouterResponseController {
       result && result.statusCode
         ? result.statusCode
         : redirectResponse.statusCode
-        ? redirectResponse.statusCode
-        : HttpStatus.FOUND;
+          ? redirectResponse.statusCode
+          : HttpStatus.FOUND;
     const url = result && result.url ? result.url : redirectResponse.url;
     this.applicationRef.redirect(response, statusCode, url);
   }

diff --git a/packages/microservices/server/server-rmq.ts b/packages/microservices/server/server-rmq.ts
@@ -153,7 +153,11 @@ export class ServerRMQ extends Server implements CustomTransportStrategy {
       (msg: Record<string, any>) => this.handleMessage(msg, channel),
       {
         noAck: this.noAck,
-        consumerTag: this.getOptionsProp(this.options, 'consumerTag', undefined)
+        consumerTag: this.getOptionsProp(
+          this.options,
+          'consumerTag',
+          undefined,
+        ),
       },
     );
     callback();

diff --git a/packages/platform-socket.io/adapters/io-adapter.ts b/packages/platform-socket.io/adapters/io-adapter.ts
@@ -23,8 +23,8 @@ export class IoAdapter extends AbstractWsAdapter {
     return server && isFunction(server.of)
       ? server.of(namespace)
       : namespace
-      ? this.createIOServer(port, opt).of(namespace)
-      : this.createIOServer(port, opt);
+        ? this.createIOServer(port, opt).of(namespace)
+        : this.createIOServer(port, opt);
   }
 
   public createIOServer(port: number, options?: any): any {