Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): display module's name on .select(module) errors #12905

Merged

Conversation

micalevisk
Copy link
Member

@micalevisk micalevisk commented Dec 10, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

when calling app.select() over modules that weren't registered, we will see the following error message:

image

What is the new behavior?

now we'll see module's name:

image

It works for dynamic modules as well

The code used in my tests:

image

This will help us to find which .select is broken

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

I also ran npm run format (commit aad263a)

@coveralls
Copy link

coveralls commented Dec 10, 2023

Pull Request Test Coverage Report for Build b7e4c207-dabf-4a59-bd05-9c1994d4ab68

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.258%

Totals Coverage Status
Change from base Build a2138bee-e39e-445f-b2ab-320ae7840dc5: 0.0%
Covered Lines: 6697
Relevant Lines: 7259

💛 - Coveralls

@micalevisk micalevisk force-pushed the feat/verbose-unknown-module-errormsg branch from aad263a to 204971c Compare December 13, 2023 17:10
@kamilmysliwiec kamilmysliwiec merged commit a1780ff into nestjs:master Dec 18, 2023
5 checks passed
@kamilmysliwiec
Copy link
Member

lgtm

@micalevisk micalevisk deleted the feat/verbose-unknown-module-errormsg branch December 18, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants