Add test case for ParseArrayPipe that doesn't work as expected #11170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On further inspection, looks like array-pipe cannot handle anything JSON-like. |
micalevisk
reviewed
Feb 27, 2023
Comment on lines
179
to
180
| await target.transform('1,2.0,3', {} as ArgumentMetadata), | ||
| ).to.deep.equal(['1', '2.0', '3']); |
There was a problem hiding this comment.
So we won't merge this because this test won't pass.
Could you please open an issue or a PR to address this bug instead?
There was a problem hiding this comment.
OK, I opened an issue to discuss this peculiar behaviour.
15 tasks
|
@thgh I think @micalevisk is asking for solution with testing rather than just test case. |
|
Alright, fix committed! |
kamilmysliwiec
approved these changes
Mar 10, 2023
|
LGTM |
This was referenced Sep 14, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
ParseArrayPipe is parsing the input as number even though String is requested.
Issue Number: N/A
What is the new behavior?
Not implemented, but it should parse only string.
Does this PR introduce a breaking change?
Other information