Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for ParseArrayPipe that doesn't work as expected #11170

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Add test case for ParseArrayPipe that doesn't work as expected #11170

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a804bf4
Add test case for ParseArrayPipe that doesn't work as expected
thgh Feb 27, 2023
96afa8e
fix: disable JSON parse for strings in ParseArrayPipe
thgh Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/common/test/pipes/parse-array.pipe.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,8 @@ describe('ParseArrayPipe', () => {

target = new ParseArrayPipe({ items: String });
expect(
await target.transform('1,2,3', {} as ArgumentMetadata),
).to.deep.equal(['1', '2', '3']);
await target.transform('1,2.0,3', {} as ArgumentMetadata),
).to.deep.equal(['1', '2.0', '3']);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we won't merge this because this test won't pass.

image

Could you please open an issue or a PR to address this bug instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I opened an issue to discuss this peculiar behaviour.


target = new ParseArrayPipe({ items: Boolean });
expect(
Expand Down