Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dolphin: allow lua for playing videos with mpv #3363

Closed
AloisJanicek opened this issue Apr 17, 2020 · 3 comments
Closed

dolphin: allow lua for playing videos with mpv #3363

AloisJanicek opened this issue Apr 17, 2020 · 3 comments

Comments

@AloisJanicek
Copy link

AloisJanicek commented Apr 17, 2020 •
edited
Loading

mpv video player launched from dolphin by clicking on video file will not start (will not appear on screen at all) unless lua is enabled in dolphin.profile.
Looks like some kind of lua repl for mpv input commands was introduced in mpv v0.31.0 released at the end of December 2019.
Prior to that playing videos in mpv launched from dolphin with click on the video file used to work without problems.

Solution
enabling lua interpreters with include allow-lua.inc in dolphin.profile

Desktop

  • Arch Linux
  • Firejail version 0.9.63 (AUR pkg firejail-git, r6095.cde87023-1)
@glitsj16
Copy link
Collaborator

Hi, thank you for reporting this issue. As it happens, I was looking into reworking all our file manager profiles to avoid issues like yours. It doesn't make much sense to block access to commonly used interpreters (like Lua, Perl, Python, ...) for that category of applications. I'll add a fix in the dolphin profile.

@rusty-snake
Copy link
Collaborator

@glitsj16 would you think removing disable-interpreters.inc makes more sense. With the current dolphin profile you can't start programs written in python, perl, ...

@glitsj16
Copy link
Collaborator

@rusty-snake Agreed. That's why I just opened #3365.

@kmk3 kmk3 changed the title Dolphin: allow lua for playing videos with mpv dolphin: allow lua for playing videos with mpv Nov 25, 2024
kmk3 added a commit to kmk3/firejail that referenced this issue Nov 25, 2024
@kmk3
profiles: ensure allow-lua where mpv is allowed
eaa75ad 
mpv crashes if luajit is blocked:

    $ firejail --quiet --noprofile \
      --include=/etc/firejail/disable-interpreters.inc /usr/bin/mpv
    /usr/bin/mpv: error while loading shared libraries: libluajit-5.1.so.2: cannot open shared object file: Permission denied

So make sure that allow-lua.inc is always included when mpv paths (such
as ~/.config/mpv) are allowed.

Environment: luajit 2.1.1727870382-1, mpv 1:0.39.0-3 on Artix Linux.

Related commits:

* db2bdaa ("add lua support for mpv (netblue30#3243)", 2020-02-24) /
  PR netblue30#3243
* d6a6fb9 ("Allow Lua for mpv in dolphin.profile", 2020-04-18) /
  issue netblue30#3363
* f3585e5 ("fixes, closes, enhances, improvements, and so on",
  2020-11-09) /
  issue netblue30#3686
* 3ec523f ("profiles: anki: allow lua", 2024-11-14) /
  PR netblue30#6545
@kmk3 kmk3 mentioned this issue Nov 25, 2024
Merged
kmk3 added a commit that referenced this issue Nov 29, 2024
@kmk3
profiles: ensure allow-lua where mpv is allowed (#6555)
e4ebbfa 
mpv crashes if luajit is blocked:

    $ firejail --quiet --noprofile \
      --include=/etc/firejail/disable-interpreters.inc /usr/bin/mpv
    /usr/bin/mpv: error while loading shared libraries: libluajit-5.1.so.2: cannot open shared object file: Permission denied

So make sure that allow-lua.inc is always included when mpv paths (such
as ~/.config/mpv) are allowed.

Environment: luajit 2.1.1727870382-1, mpv 1:0.39.0-3 on Artix Linux.

Related commits:

* db2bdaa ("add lua support for mpv (#3243)", 2020-02-24) /
  PR #3243
* d6a6fb9 ("Allow Lua for mpv in dolphin.profile", 2020-04-18) /
  issue #3363
* f3585e5 ("fixes, closes, enhances, improvements, and so on",
  2020-11-09) /
  issue #3686
* 3ec523f ("profiles: anki: allow lua", 2024-11-14) /
  PR #6545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AloisJanicek @glitsj16 @rusty-snake