Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DATA_UPLOAD_MAX_MEMORY_SIZE as an configurable variable #12872

Closed
ziggekatten opened this issue Jun 12, 2023 · 3 comments · Fixed by #13999
Closed

Add DATA_UPLOAD_MAX_MEMORY_SIZE as an configurable variable #12872

ziggekatten opened this issue Jun 12, 2023 · 3 comments · Fixed by #13999
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@ziggekatten
Copy link

NetBox version

v3.5.3

Feature type

New functionality

Proposed functionality

Add to settings.py: DATA_UPLOAD_MAX_MEMORY_SIZE = getattr(configuration, 'DATA_UPLOAD_MAX_MEMORY_SIZE', 2621440)

Use case

We use custom scripts, called through the API for data validation, and there is an hard limit on 2,6MB on the payload (body). We have cases were we are well above that (posting an JSON with all VM's fron an vCenter for validation), and I therefore suggest that variable is being added to the settings.py just as the file upload variable. Tests by setting this in settings.py our selves solves the challenge, but one must remember this when upgrading....

Database changes

None

External dependencies

None

@ziggekatten ziggekatten added the type: feature Introduction of new functionality to the application label Jun 12, 2023
@jeremystretch
Copy link
Member

Does this need to be configurable? Should we just set it to a much higher (but sane) value, or disable it entirely?

@jeremystretch jeremystretch added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Jun 14, 2023
@ziggekatten
Copy link
Author

ziggekatten commented Jun 15, 2023

I suggest it to be configured so one can limit it to its own need, with the default as is (~2,5 MB).

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions github-actions bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Sep 14, 2023
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation pending closure Requires immediate attention to avoid being closed for inactivity labels Oct 6, 2023
@jeremystretch jeremystretch self-assigned this Oct 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants