Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InventoryItem filters - Device Roles are mapped to InventoryItem Roles #14013

Closed
Kani999 opened this issue Oct 10, 2023 · 1 comment · Fixed by #14028
Closed

InventoryItem filters - Device Roles are mapped to InventoryItem Roles #14013

Kani999 opened this issue Oct 10, 2023 · 1 comment · Fixed by #14028
Assignees
@arthanson
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@Kani999
Copy link

Kani999 commented Oct 10, 2023

NetBox version

v3.6.3

Python version

3.10

Steps to Reproduce

  1. Go to Inventory Item list view (netbo-url/dcim/inventory-items/)
  2. Click on Filters
  3. Scroll to Device filter option
  4. Select Device Role
    • Inventory Item roles are displayed instead of Device roles

image

The InventoryItem role can also be selected in the top of the filters in section Attributes

Expected Behavior

Filtering Device roles at the Device section of filters

Observed Behavior

Filtering InventoryItem roles at the Device section of filters
@Kani999 Kani999 added the type: bug A confirmed report of unexpected behavior in the application label Oct 10, 2023
@Kani999
Copy link
Author

Kani999 commented Oct 10, 2023

I suppose https://github.com/netbox-community/netbox/blob/4286c1cde255a9bf146b3b192e1ac17566af0094/netbox/dcim/forms/filtersets.py#L1392C1-L1393C1 the fieldsets have both for Device and Attributes set the same role_id.
So it should be renamed to something like inventory_item_role_id when the role_id is defined in the DeviceComponentFilterForm

@DanSheps DanSheps added status: accepted This issue has been accepted for implementation severity: low Does not significantly disrupt application functionality, or a workaround is available labels Oct 11, 2023
@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: accepted This issue has been accepted for implementation labels Oct 12, 2023
@arthanson arthanson self-assigned this Oct 12, 2023
@arthanson arthanson removed the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Oct 12, 2023
@arthanson arthanson mentioned this issue Oct 12, 2023
Merged
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Oct 13, 2023
jeremystretch added a commit that referenced this issue Oct 13, 2023
@jeremystretch
Changelog for #12872, #14013, #14023, #14026
14447be
@jeremystretch jeremystretch mentioned this issue Oct 17, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@arthanson arthanson

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

14013 fix device role filter netbox-community/netbox
4 participants
@arthanson @DanSheps @jeremystretch @Kani999