Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of exclamation mark (!) in Custom Links not possible #14560

Closed
Azmodeszer opened this issue Dec 19, 2023 · 2 comments · Fixed by #14581
Closed

Usage of exclamation mark (!) in Custom Links not possible #14560

Azmodeszer opened this issue Dec 19, 2023 · 2 comments · Fixed by #14581
Assignees
@Azmodeszer
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@Azmodeszer
Copy link
Contributor

Azmodeszer commented Dec 19, 2023 •
edited
Loading

Deployment Type

Self-hosted

NetBox Version

3.6.6

Python Version

3.11

Steps to Reproduce

  1. Set up a Custom Link.
  2. Put https://<IP>/screens/dashboard.html#!/APView/{{ object.interfaces.filter(mac_address__isnull=False).first().mac_address }} as the Link URL.

Similar to #13011. Also see #14553.

Expected Behavior

The URL should be rendered with the ! intact.

Observed Behavior

The ! is encoded as %21, resulting in a broken link.
@Azmodeszer Azmodeszer added the type: bug A confirmed report of unexpected behavior in the application label Dec 19, 2023
@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available labels Dec 21, 2023
@jeremystretch
Copy link
Member

The exclamation mark probably needs to be added to the list of characters excluded from escaping when calling urllib.parse.quote().

@Azmodeszer
Copy link
Contributor Author

I can own this and do the pull request, no problem.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Dec 21, 2023
@Azmodeszer Azmodeszer mentioned this issue Dec 21, 2023
Merged
jeremystretch added a commit that referenced this issue Dec 21, 2023
@jeremystretch
Changelog for #14507, #14538, #14549, #14560, #14575
c289dda
@jeremystretch jeremystretch mentioned this issue Dec 27, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Azmodeszer Azmodeszer

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added ! to safe characters Azmodeszer/netbox
2 participants
@jeremystretch @Azmodeszer