Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EVPN-VPWS to the L2VPNTypeChoices Choice set. #17216

Closed
caskings opened this issue Aug 20, 2024 · 4 comments · Fixed by #17694
Closed

Add EVPN-VPWS to the L2VPNTypeChoices Choice set. #17216

caskings opened this issue Aug 20, 2024 · 4 comments · Fixed by #17694
Assignees
@caskings
Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@caskings
Copy link
Contributor

NetBox version

v4.0.9

Feature type

Data model extension

Proposed functionality

EVPN-VPWS is a point to point L2VPN service that breaks the current model for VPWS and other P2P types in the L2VPN termination list as it allows for multiple interfaces across multiple network devices to the same endpoint or location. In either an Active / Active or Active / Passive mode.

Suggested change

Add TYPE_EVPN_VPWS to the L2VPNTypeChoices class, but don't add it to L2VPNTypeChoices.P2P

Relevant RFC: https://datatracker.ietf.org/doc/html/rfc8214

Use case

This would allow Netbox users to model EVPN-VPWS separately from RFC4664 type VPWS which doesn't support Active / Active across multiple devices to the same location.

Database changes

No response

External dependencies

No response
@caskings caskings added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels Aug 20, 2024
@Brekmister
Copy link

My work is moving towards EVPN-VPWS as well. This would be a nice addition to model.

@DanSheps DanSheps added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation complexity: low Requires minimal effort to implement and removed status: needs triage This issue is awaiting triage by a maintainer labels Aug 22, 2024
@caskings
Copy link
Contributor Author

@DanSheps I'm happy to have a go at creating a pull request for this.

@ajackson79
Copy link

Adding another voice to this in hopes it gets added.

@DanSheps DanSheps added the status: accepted This issue has been accepted for implementation label Sep 9, 2024
@DanSheps
Copy link
Member

DanSheps commented Sep 9, 2024

@caskings Added you to work on it, please proceed with the PR

@DanSheps DanSheps removed the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Sep 9, 2024
@caskings caskings mentioned this issue Oct 8, 2024
Merged
jeremystretch added a commit that referenced this issue Oct 9, 2024
@jeremystretch
Changelog for #17216, #17562, #17636
8e636c5
bctiemann pushed a commit that referenced this issue Oct 11, 2024
@jeremystretch @bctiemann
Changelog for #17216, #17562, #17636
864acf5
jeremystretch added a commit to alehaa/netbox that referenced this issue Oct 11, 2024
@jeremystretch
Changelog for netbox-community#17216, netbox-community#17562, netbox-…
ef49ecb 
…community#17636
@jeremystretch jeremystretch mentioned this issue Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caskings caskings

Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add EVPN-VPWS to L2VPNTypeChoices caskings/netbox
4 participants
@caskings @Brekmister @DanSheps @ajackson79