Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EVPN-VPWS to L2VPNTypeChoices #17694

Conversation

caskings
Copy link
Contributor

@caskings caskings commented Oct 8, 2024

Fixes: #17216

Updated L2VPNTypeChoices to include the EVPN-VPWS type but didn't include it in the P2P list so more than two interfaces can be assigned to it.

Copy link
Member

@DanSheps DanSheps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to leave a little background on the PR. While a VPWS is a Point-to-Point protocol, current in NetBox we have no way to properly model the relationship between two devices that are part of a MC-LAG using EVPN ESI (The chassis' don't talk to each other over a MC-LAG protocol, they use EVPN to build the MC-LAG; I believe technically a chassis could be part of an MC-LAG with one device on one bundle and then part of a different MC-LAG with a different bundle, but I haven't dove too far into it)

So you would either need to model two VPWS and link them together (maybe a parent/child relationship), build a new model to bridge the two devices for MC-LAG or allow a multi-connect like this. I think this is the more reasonable way to handle it for no, anything else would require substantial effort.

@jeremystretch jeremystretch merged commit 2172ddd into netbox-community:develop Oct 9, 2024
3 checks passed
@caskings caskings deleted the add-evpn-vpws-to-L2VPNTypeChoices branch October 9, 2024 23:32
bctiemann pushed a commit that referenced this pull request Oct 11, 2024
* Add EVPN-VPWS to the availbable L2VPN Connection Types

* Updated documentation to reference the new L2VPN type.
jeremystretch pushed a commit to alehaa/netbox that referenced this pull request Oct 11, 2024
* Add EVPN-VPWS to the availbable L2VPN Connection Types

* Updated documentation to reference the new L2VPN type.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add EVPN-VPWS to the L2VPNTypeChoices Choice set.
3 participants