Skip to content

Commit

Permalink
chore(docs-pr-template): update PR submission steps (#3503)
Browse files Browse the repository at this point in the history
  • Loading branch information
erezrokah authored Oct 19, 2021
1 parent bf3c0c5 commit 0d2708e
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 21 deletions.
34 changes: 14 additions & 20 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,28 +1,22 @@
<!--
Thanks for submitting a pull request!
Please make sure you've read and understood our contributing guidelines;
https://github.com/netlify/netlify-cli/blob/main/CONTRIBUTING.md
πŸŽ‰ Thanks for submitting a pull request! πŸŽ‰

If this is a bug fix, make sure your description includes "fixes #xxxx", or
"closes #xxxx", where #xxxx is the issue number.
Please provide enough information so that others can review your pull request.
The first three fields are mandatory:
-->
#### Summary

**- Summary**
Fixes #<replace_with_issue_number>

<!--
Explain the **motivation** for making this change.
What existing problem does the pull request solve?
Explain the **motivation** for making this change. What existing problem does the pull request solve and how?
-->

**- Test plan**
---

<!--
Demonstrate the code is solid.
Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
-->
For us to review and ship your PR efficiently, please perform the following steps:

- [ ] Open a [bug/issue](https://github.com/netlify/cli/issues/new/choose) before writing your code πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you\`re fixing a typo or something that\`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
- [ ] Read the [contribution guidelines](../CONTRIBUTING.md) πŸ“–. This ensures your code follows our style guide and
passes our tests.
- [ ] Update or add tests (if any source code was changed or added) πŸ§ͺ
- [ ] Update or add documentation (if features were changed or added) πŸ“
- [ ] Make sure the status checks below are successful βœ…

**- A picture of a cute animal (not mandatory but encouraged)**
**A picture of a cute animal (not mandatory, but encouraged)**
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
},
"config": {
"eslint": "--ignore-path .gitignore --cache --format=codeframe --max-warnings=0 \"{src,scripts,site,tests,.github}/**/*.{js,md,html}\" \"*.{js,md,html}\" \".*.{js,md,html}\"",
"prettier": "--ignore-path .gitignore --loglevel=warn \"{src,scripts,site,tests,.github}/**/*.{js,md,yml,json,html}\" \"*.{js,yml,json,html}\" \".*.{js,yml,json,html}\" \"!CHANGELOG.md\" \"!npm-shrinkwrap.json\""
"prettier": "--ignore-path .gitignore --loglevel=warn \"{src,scripts,site,tests,.github}/**/*.{js,md,yml,json,html}\" \"*.{js,yml,json,html}\" \".*.{js,yml,json,html}\" \"!CHANGELOG.md\" \"!npm-shrinkwrap.json\" \"!.github/**/*.md\""
},
"dependencies": {
"@netlify/build": "^18.17.1",
Expand Down

1 comment on commit 0d2708e

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ“Š Benchmark results

Package size: 357 MB

Please sign in to comment.