chore: update PR template #3503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: chore
📊 Benchmark resultsComparing with bf3c0c5 Package size: 357 MB(no change) Legend
|
erezrokah
commented
Oct 14, 2021
erezrokah
force-pushed
the
chore/update_pr_template
branch
from
968a719 to
4d85574
Compare
ehmicky
approved these changes
Oct 14, 2021
erezrokah
force-pushed
the
chore/update_pr_template
branch
from
f0f4058 to
0172324
Compare
erezrokah
commented
Oct 19, 2021
| @@ -76,7 +76,7 @@ | |||
| }, | |||
| "config": { | |||
| "eslint": "--ignore-path .gitignore --cache --format=codeframe --max-warnings=0 \"{src,scripts,site,tests,.github}/**/*.{js,md,html}\" \"*.{js,md,html}\" \".*.{js,md,html}\"", | |||
| "prettier": "--ignore-path .gitignore --loglevel=warn \"{src,scripts,site,tests,.github}/**/*.{js,md,yml,json,html}\" \"*.{js,yml,json,html}\" \".*.{js,yml,json,html}\" \"!CHANGELOG.md\" \"!npm-shrinkwrap.json\"" | |||
| "prettier": "--ignore-path .gitignore --loglevel=warn \"{src,scripts,site,tests,.github}/**/*.{js,md,yml,json,html}\" \"*.{js,yml,json,html}\" \".*.{js,yml,json,html}\" \"!CHANGELOG.md\" \"!npm-shrinkwrap.json\" \"!.github/**/*.md\"" | |||
There was a problem hiding this comment.
This is needed to avoid prettier line wrapping the text in the markdown file.
Once prettier/prettier#8506 is resolved, we should be able to use both .gitignore and .prettierignore for this
ehmicky
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the PR template to include detailed steps