-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update PR template #3503
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,22 @@ | ||
<!-- | ||
Thanks for submitting a pull request! | ||
|
||
Please make sure you've read and understood our contributing guidelines; | ||
https://github.com/netlify/netlify-cli/blob/main/CONTRIBUTING.md | ||
🎉 Thanks for submitting a pull request! 🎉 | ||
|
||
If this is a bug fix, make sure your description includes "fixes #xxxx", or | ||
"closes #xxxx", where #xxxx is the issue number. | ||
|
||
Please provide enough information so that others can review your pull request. | ||
The first three fields are mandatory: | ||
--> | ||
#### Summary | ||
|
||
**- Summary** | ||
Fixes #<replace_with_issue_number> | ||
|
||
<!-- | ||
Explain the **motivation** for making this change. | ||
What existing problem does the pull request solve? | ||
Explain the **motivation** for making this change. What existing problem does the pull request solve and how? | ||
--> | ||
|
||
**- Test plan** | ||
--- | ||
|
||
<!-- | ||
Demonstrate the code is solid. | ||
Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. | ||
--> | ||
For us to review and ship your PR efficiently, please perform the following steps: | ||
|
||
- [ ] Open a [bug/issue](https://github.com/netlify/cli/issues/new/choose) before writing your code 🧑💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you\`re fixing a typo or something that\`s on fire 🔥 (e.g. incident related), you can skip this step. | ||
- [ ] Read the [contribution guidelines](../CONTRIBUTING.md) 📖. This ensures your code follows our style guide and | ||
passes our tests. | ||
- [ ] Update or add tests (if any source code was changed or added) 🧪 | ||
- [ ] Update or add documentation (if features were changed or added) 📝 | ||
- [ ] Make sure the status checks below are successful ✅ | ||
|
||
**- A picture of a cute animal (not mandatory but encouraged)** | ||
**A picture of a cute animal (not mandatory, but encouraged)** |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed to avoid prettier line wrapping the text in the markdown file.
Once prettier/prettier#8506 is resolved, we should be able to use both
.gitignore
and.prettierignore
for this