Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump and activate netlify-plugin-chromium #93

Merged
merged 2 commits into from
Jun 11, 2020
Merged

Bump and activate netlify-plugin-chromium #93

merged 2 commits into from
Jun 11, 2020

Conversation

soofka
Copy link

@soofka soofka commented Jun 11, 2020

Thanks for contributing the the Netlify plugins directory!

Are you adding a plugin or updating one?

  • Adding a plugin
  • Updating a plugin

Plugin version diff

https://diff.intrinsic.com/netlify-plugin-chromium/1.1.1/1.1.4

Have you completed the following?

Test plan
https://app.netlify.com/sites/amazing-morse-5b1303/deploys/5ee27b6145fc4e0007a159df

Between 8:44:57 and 8:45:27 the plugin is triggered and you can see Chromium being installed. Then at 8:46:24 Lighthouse CI is triggered and Chromium is recognized as available, thus further steps of Lighthouse process are performed.

@soofka soofka closed this Jun 11, 2020
@soofka soofka reopened this Jun 11, 2020
@ehmicky ehmicky self-requested a review June 11, 2020 19:03
@ehmicky ehmicky added the type: bug code to address defects in shipped code label Jun 11, 2020
Copy link
Contributor

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @soofka!

@ehmicky ehmicky merged commit cfd2efe into netlify:master Jun 11, 2020
@soofka
Copy link
Author

soofka commented Jun 11, 2020

Thanks @ehmicky!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants