Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename onInstall #1

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Rename onInstall #1

merged 1 commit into from
Jun 11, 2020

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented May 18, 2020

The onInstall event handler will be removed soon as it is not implemented yet. In the meantime, the onPreBuild should do the same. This PR implements this renaming.

@soofka soofka merged commit 0b64d77 into soofka:master Jun 11, 2020
@soofka
Copy link
Owner

soofka commented Jun 11, 2020

Hi @ehmicky! Thanks for the PR and sorry you had to wait. I merged your changes and published the plugin (version 1.1.3) to NPM.

@ehmicky ehmicky deleted the chore/rename-on-install branch June 11, 2020 18:40
@ehmicky
Copy link
Contributor Author

ehmicky commented Jun 11, 2020

Hi @soofka,

Thanks a lot!
Would it be ok to notify about the new version by sending a PR to update the version field in the plugins.json file of https://github.com/netlify/plugins?

You can also remove the status: "DEACTIVATED" field. This field was due to the General Availability of Build plugins 2 weeks ago, which introduced many breaking changes. This made several plugins, including this one, not working with the latest version of Build plugins, so we had to temporarily hide those plugins from the Netlify App UI until the PRs to fix them got merged. Thanks!

@soofka
Copy link
Owner

soofka commented Jun 11, 2020

I'm on it!

@soofka
Copy link
Owner

soofka commented Jun 11, 2020

Done: netlify/plugins#93. However, I didn't pass check for tags. I'm not very experienced with GitHub (clearly) and I can't really find an option to add tags to this PR (I tried to create it again and didn't find it too) so I guess I'll leave it like that for now ¯\_(ツ)_/¯

@ehmicky
Copy link
Contributor Author

ehmicky commented Jun 11, 2020

Our company is mandating that every PR has a type: ... tag to categorize between feature, bugs, chore and security. This is mostly something I add on every PR coming to that repository, no worries there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants