feat(remix-edge-adapter)!: remove future flags from default config #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for hydrogen-demo-site failed.
|
✅ Deploy Preview for remix-serverless ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for remix-edge ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
MichaelDeBoey
force-pushed
the
remove-future-flags-from-default-config
branch
2 times, most recently
from
fc7039b to
8edd00c
Compare
|
@nickytonline Is there something I should still do to get this one merged? |
MichaelDeBoey
force-pushed
the
remove-future-flags-from-default-config
branch
2 times, most recently
from
81af5fc to
c29449c
Compare
✅ Deploy Preview for remix-serverless ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
MichaelDeBoey
force-pushed
the
remove-future-flags-from-default-config
branch
from
c29449c to
cf4d0dd
Compare
|
@nickytonline closing this as this was implemented in #191 as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding/removing a future flag would be a breaking change each time, so it's better to keep this in the template itself imo
This would be a breaking change, but we haven't published
@netlify/remix-edge-adapterv2 yet, so we can just merge this in safely without another breaking change imoCC/ @nickytonline