feat!: upgrade to Remix 2 #191

ascorbic · 2023-10-16T20:12:46Z

Description

Update adapters and edge runtime to Remix 2, and to Functions API v2. Switches to using our custom server during dev in edge, now that there's better support for this. Moves everything to ESM now that's required.

There is a separate PR to update the template once this is out.

Related Tickets & Documents

Related Issue #
Fixes FRA-48

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes

For us to review and ship your PR efficiently, please perform the following steps:

Open a bug/issue before writing your code 🧑‍💻. This
ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a
typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
Read the contribution guidelines 📖. This ensures your code follows our style
guide and passes our tests.
Update or add tests (if any source code was changed or added) 🧪
Update or add documentation (if features were changed or added) 📝
Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

netlify · 2023-10-16T20:12:52Z

✅ Deploy Preview for remix-serverless ready!

Name	Link
🔨 Latest commit	`942bf87`
🔍 Latest deploy log	https://app.netlify.com/sites/remix-serverless/deploys/65315c60caafab00086dbc06
😎 Deploy Preview	https://deploy-preview-191--remix-serverless.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2023-10-16T20:12:54Z

✅ Deploy Preview for remix-edge ready!

Name	Link
🔨 Latest commit	`942bf87`
🔍 Latest deploy log	https://app.netlify.com/sites/remix-edge/deploys/65315c6085542f0008e65f40
😎 Deploy Preview	https://deploy-preview-191--remix-edge.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ascorbic · 2023-10-18T05:55:14Z

.github/workflows/test.yml

-      - name: Run unit tests
-        run: npm test


These were just the Netlify adapter tests ported from Remix repo. See below for why they were removed.

ascorbic · 2023-10-18T05:55:38Z

packages/demo-site/.eslintrc

+{
+  "extends": ["@remix-run/eslint-config", "@remix-run/eslint-config/node"],
+}


Changed to json because of ESM

ESLint v9 is going to remove support for JSON .eslintrc files

ascorbic · 2023-10-18T06:07:53Z

packages/demo-site/server.ts

@@ -1,10 +1,17 @@
 import * as build from '@remix-run/dev/server-build'
 import { createRequestHandler } from '@netlify/remix-adapter'
-import { installGlobals } from '@remix-run/node'


We don't want to use Remix versions of web streams

ascorbic · 2023-10-18T06:08:39Z

packages/edge-demo-site/app/entry.server.tsx

  request: Request,
  responseStatusCode: number,
  responseHeaders: Headers,
  remixContext: EntryContext,
  loadContext: AppLoadContext,
 ) {
-  const markup = renderToString(<RemixServer context={remixContext} url={request.url} />)
+  const body = await renderToReadableStream(<RemixServer context={remixContext} url={request.url} />, {


Streaming works now

ascorbic · 2023-10-18T07:41:03Z

packages/demo-site/app/entry.server.tsx

+          // Avoid a bug where responses aren't flushed if there's an outstanding timer.
+          clearTimeout(timer)


https://github.com/netlify/pod-dev-foundations/issues/604

ascorbic · 2023-10-18T07:42:39Z

packages/demo-site/remix.config.js

  ignoredRouteFiles: ['**/.*'],
-  server: process.env.NETLIFY || process.env.NETLIFY_LOCAL ? './server.ts' : undefined,


We can now use our custom server in dev

ascorbic · 2023-10-18T07:43:11Z

packages/edge-demo-site/app/entry.server.tsx

@@ -1,25 +1,30 @@
-/**
- * By default, Remix will handle generating the HTTP Response for you.
- * You are free to delete this file if you'd like to, but if you ever want it revealed again, you can run `npx remix reveal` ✨


ascorbic · 2023-10-18T07:43:57Z

packages/edge-demo-site/package.json

  "scripts": {
    "prebuild": "cd ../../ && npm run build -w=packages/remix-runtime && npm run build -w=packages/remix-edge-adapter && npm run build -w=packages/remix-adapter",
    "build": "remix build",
-    "dev": "remix watch",
+    "dev": "remix dev --manual -c \"ntl dev --framework=#static\"",


The remix server now runs the netlify CLI rather than the other way around

ascorbic · 2023-10-18T07:45:12Z

packages/remix-adapter/__tests__/server.test.ts

These tests were all for the workarounds that translated the Remix responses into Netlify/Lambda-compatible ones. These are no longer needed with Functions v2, because we can return the Reponse directly

ascorbic · 2023-10-18T07:46:13Z

packages/remix-adapter/src/server.ts

This is now effectively the same as the edge server

ascorbic · 2023-10-18T17:18:51Z

❌ Deploy Preview for hydrogen-demo-site failed.

Name Link
🔨 Latest commit 77694d9
🔍 Latest deploy log https://app.netlify.com/sites/hydrogen-demo-site/deploys/652f7277b6c7780008aff8cd

This site no longer exists. I've disabled builds.

pieh

Seems good - need to resolve package-lock.json conflict and will have to re-approve after that

feat!: upgrade to Remix 2

2781e73

ascorbic requested a review from a team as a code owner October 16, 2023 20:12

This comment was marked as outdated.

Sign in to view

github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Oct 16, 2023

ascorbic added 2 commits October 16, 2023 21:41

chore: fix edge demo site

59148c0

chore: fix edge demo site

a86e144

ascorbic marked this pull request as draft October 16, 2023 21:03

chore: fix edge demo site

74e2621

ascorbic force-pushed the v2 branch from a5f953c to 74e2621 Compare October 17, 2023 06:00

ascorbic added 4 commits October 17, 2023 07:10

chore: add log

92b346f

chore: wip functions v2

143eabe

fix: further v2 updates

be3dbcf

chore: add remix devdep

310d766

ascorbic force-pushed the v2 branch 5 times, most recently from 80e3fa6 to 5a9314e Compare October 17, 2023 15:34

chore: fix build command

f6ad837

ascorbic force-pushed the v2 branch from 5a9314e to f6ad837 Compare October 17, 2023 15:58

ascorbic added 8 commits October 17, 2023 19:18

chore: test without handler

385dcb8

chore: re-enable

6d6a7f9

chore: try with a different response

f9187b1

chore: revert to og handler and add logs

297cf3f

chore: add logging stream

dcf3226

chore: clear timeout

b4c3a0f

chore: simplify server entry

76b52f8

chore: fix linting

82ee287

ascorbic added 2 commits October 18, 2023 06:51

chore: remove unused test files

77694d9

chore: update defaults and remove debug stuff

c2dfe08

ascorbic commented Oct 18, 2023

View reviewed changes

ascorbic marked this pull request as ready for review October 18, 2023 07:48

chore: rename test

dc4cdbb

pieh previously approved these changes Oct 19, 2023

View reviewed changes

ascorbic dismissed pieh’s stale review via 174529e October 19, 2023 15:34

pieh previously approved these changes Oct 19, 2023

View reviewed changes

ascorbic enabled auto-merge (squash) October 19, 2023 15:35

ascorbic dismissed pieh’s stale review via e684bd1 October 19, 2023 16:22

ascorbic force-pushed the v2 branch from 174529e to e684bd1 Compare October 19, 2023 16:22

Merge branch 'main' into v2

942bf87

ascorbic force-pushed the v2 branch from e684bd1 to 942bf87 Compare October 19, 2023 16:42

pieh approved these changes Oct 19, 2023

View reviewed changes

ascorbic merged commit 81b169f into main Oct 19, 2023
14 checks passed

ascorbic deleted the v2 branch October 19, 2023 17:00

token-generator-app bot mentioned this pull request Oct 19, 2023

chore: release main #195

Merged

This was referenced Oct 27, 2023

feat(remix-edge-adapter)!: remove future flags from default config #152

Closed

chore: update Remix version #168

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: upgrade to Remix 2 #191

feat!: upgrade to Remix 2 #191

ascorbic commented Oct 16, 2023 •

edited by MarcL

Loading

netlify bot commented Oct 16, 2023 •

edited

Loading

This comment was marked as outdated.

netlify bot commented Oct 16, 2023 •

edited

Loading

ascorbic Oct 18, 2023

ascorbic Oct 18, 2023

MichaelDeBoey Oct 27, 2023

ascorbic Oct 18, 2023

ascorbic Oct 18, 2023

ascorbic Oct 18, 2023

ascorbic Oct 18, 2023

ascorbic Oct 18, 2023

ascorbic Oct 18, 2023

ascorbic Oct 18, 2023

ascorbic Oct 18, 2023

ascorbic commented Oct 18, 2023 •

edited

Loading

❌ Deploy Preview for hydrogen-demo-site failed.

pieh left a comment

		// Avoid a bug where responses aren't flushed if there's an outstanding timer.
		clearTimeout(timer)

		ignoredRouteFiles: ['*/.'],
		server: process.env.NETLIFY \|\| process.env.NETLIFY_LOCAL ? './server.ts' : undefined,

feat!: upgrade to Remix 2 #191

feat!: upgrade to Remix 2 #191

Conversation

ascorbic commented Oct 16, 2023 • edited by MarcL Loading

Description

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

netlify bot commented Oct 16, 2023 • edited Loading

✅ Deploy Preview for remix-serverless ready!

This comment was marked as outdated.

netlify bot commented Oct 16, 2023 • edited Loading

✅ Deploy Preview for remix-edge ready!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ascorbic commented Oct 18, 2023 • edited Loading

❌ Deploy Preview for hydrogen-demo-site failed.

pieh left a comment

Choose a reason for hiding this comment

ascorbic commented Oct 16, 2023 •

edited by MarcL

Loading

netlify bot commented Oct 16, 2023 •

edited

Loading

netlify bot commented Oct 16, 2023 •

edited

Loading

ascorbic commented Oct 18, 2023 •

edited

Loading