fix: add feature flag for the inheritance of the Node.js version from…

… build (#1394)

* fix: add feature flag for the inheritance of the Node.js version from build

* Update feature_flags.ts

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

src/feature_flags.ts

@@ -1,6 +1,6 @@
 import { env } from 'process'
 
-export const defaultFlags: Record<string, boolean> = {
+export const defaultFlags = {
   // Build Rust functions from source.
   buildRustSource: Boolean(env.NETLIFY_EXPERIMENTAL_BUILD_RUST_SOURCE),
 
@@ -10,6 +10,9 @@ export const defaultFlags: Record<string, boolean> = {
   // Use NFT as the default bundler.
   traceWithNft: false,
 
+  // Should Lambda functions inherit the build Node.js version
+  functions_inherit_build_nodejs_version: false,
+
   // Output pure (i.e. untranspiled) ESM files when the function file has ESM
   // syntax and the parent `package.json` file has `{"type": "module"}`.
   zisi_pure_esm: false,
@@ -26,10 +29,9 @@ export const defaultFlags: Record<string, boolean> = {
 
   // Inject the compatibility layer required for the v2 runtime API to work.
   zisi_functions_api_v2: false,
-}
+} as const
 
-export type FeatureFlag = keyof typeof defaultFlags
-export type FeatureFlags = Record<FeatureFlag, boolean>
+export type FeatureFlags = Partial<Record<keyof typeof defaultFlags, boolean>>
 
 // List of supported flags and their default value.
 

src/manifest.ts

@@ -2,7 +2,8 @@ import { promises as fs } from 'fs'
 import { resolve } from 'path'
 import { arch, platform } from 'process'
 
-import { FunctionResult } from './utils/format_result.js'
+import type { FeatureFlags } from './feature_flags.js'
+import type { FunctionResult } from './utils/format_result.js'
 
 interface ManifestFunction {
   mainFile: string
@@ -28,8 +29,16 @@ export interface Manifest {
 
 const MANIFEST_VERSION = 1
 
-export const createManifest = async ({ functions, path }: { functions: FunctionResult[]; path: string }) => {
-  const formattedFunctions = functions.map(formatFunctionForManifest)
+export const createManifest = async ({
+  featureFlags,
+  functions,
+  path,
+}: {
+  featureFlags: FeatureFlags
+  functions: FunctionResult[]
+  path: string
+}) => {
+  const formattedFunctions = functions.map((func) => formatFunctionForManifest(func, featureFlags))
   const payload: Manifest = {
     functions: formattedFunctions,
     system: { arch, platform },
@@ -40,23 +49,16 @@ export const createManifest = async ({ functions, path }: { functions: FunctionR
   await fs.writeFile(path, JSON.stringify(payload))
 }
 
-const formatFunctionForManifest = ({
-  bundler,
-  displayName,
-  generator,
-  mainFile,
-  name,
-  path,
-  runtime,
-  runtimeVersion,
-  schedule,
-}: FunctionResult): ManifestFunction => ({
+const formatFunctionForManifest = (
+  { bundler, displayName, generator, mainFile, name, path, runtime, runtimeVersion, schedule }: FunctionResult,
+  featureFlags: FeatureFlags,
+): ManifestFunction => ({
   bundler,
   displayName,
   generator,
   mainFile,
   name,
-  runtimeVersion,
+  runtimeVersion: featureFlags.functions_inherit_build_nodejs_version ? runtimeVersion : undefined,
   path: resolve(path),
   runtime,
   schedule,

src/runtimes/node/bundlers/types.ts

@@ -1,7 +1,7 @@
 import type { Message } from '@netlify/esbuild'
 
 import type { FunctionConfig } from '../../../config.js'
-import type { FeatureFlag, FeatureFlags } from '../../../feature_flags.js'
+import type { FeatureFlags } from '../../../feature_flags.js'
 import type { FunctionSource } from '../../../function.js'
 import { ObjectValues } from '../../../types/utils.js'
 import type { RuntimeCache } from '../../../utils/cache.js'
@@ -29,7 +29,7 @@ export type BundleFunction = (
     basePath?: string
     cache: RuntimeCache
     config: FunctionConfig
-    featureFlags: Record<FeatureFlag, boolean>
+    featureFlags: FeatureFlags
     pluginsModulesPath?: string
     repositoryRoot?: string
   } & FunctionSource,

src/zip.ts

@@ -136,7 +136,7 @@ export const zipFunctions = async function (
   )
 
   if (manifest !== undefined) {
-    await createManifest({ functions: formattedResults, path: resolve(manifest) })
+    await createManifest({ featureFlags, functions: formattedResults, path: resolve(manifest) })
   }
 
   return formattedResults