This repository has been archived by the owner on May 22, 2024. It is now read-only.
fix: add feature flag for the inheritance of the Node.js version from build #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
commented
Apr 20, 2023
|
|
||
| export type FeatureFlag = keyof typeof defaultFlags | ||
| export type FeatureFlags = Record<FeatureFlag, boolean> | ||
| export type FeatureFlags = Partial<Record<keyof typeof defaultFlags, boolean>> |
There was a problem hiding this comment.
The type changes make it so that we have autocompletion and validation for all feature flags. The are Partial because it would be totally valid to input an empty object for example.
⏱ Benchmark resultsComparing with 3ba9b49 largeDepsEsbuild: 2.1s⬇️ 1.61% decrease vs. 3ba9b49 LegendlargeDepsNft: 8.7s⬆️ 3.66% increase vs. 3ba9b49 LegendlargeDepsZisi: 16s⬆️ 0.58% increase vs. 3ba9b49 |
khendrikse
previously approved these changes
Apr 21, 2023
No i mean |
khendrikse
approved these changes
Apr 24, 2023
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
May 21, 2024
… build (netlify/zip-it-and-ship-it#1394) * fix: add feature flag for the inheritance of the Node.js version from build * Update feature_flags.ts --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I just want to make sure, we can turn this feature off completely. a featureFlag in build would actually not be able to 100% disable it.
Ref: https://github.com/netlify/pod-compute/issues/64
For us to review and ship your PR efficiently, please perform the following steps:
This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing
a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)