Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enabling Go Pprof #308

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Allow enabling Go Pprof #308

merged 2 commits into from
Sep 20, 2022

Conversation

mariomac
Copy link

If the profile.port argument is set to something different than 0, it will add a pprof endpoint so we can inspect what's going on FLP in terms of memory and CPU.

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022

Codecov Report

Merging #308 (1bf6822) into main (ef4a155) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
- Coverage   68.67%   68.57%   -0.11%     
==========================================
  Files          81       81              
  Lines        4699     4706       +7     
==========================================
  Hits         3227     3227              
- Misses       1276     1283       +7     
  Partials      196      196              
Flag Coverage Δ
unittests 68.57% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/flowlogs-pipeline/main.go 0.00% <0.00%> (ø)
pkg/config/config.go 63.63% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jotak
Copy link
Member

jotak commented Sep 16, 2022

Thanks Mario,
Can you document how to use it? (or link to external doc)

@jotak
Copy link
Member

jotak commented Sep 19, 2022

/lgtm
but a short documentation on how to use it would be nice

@mariomac
Copy link
Author

@jotak I'll add the actual documentation in the NOO repo, as a new PR.

@mariomac mariomac merged commit 948dc3c into netobserv:main Sep 20, 2022
@mariomac mariomac deleted the pprof branch September 20, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants