Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow enabling profiler port in FLP #167

Merged
merged 4 commits into from
Sep 21, 2022
Merged

Allow enabling profiler port in FLP #167

merged 4 commits into from
Sep 21, 2022

Conversation

mariomac
Copy link
Contributor

jotak
jotak reviewed Sep 16, 2022
View reviewed changes
api/v1alpha1/flowcollector_types.go
//+kubebuilder:validation:Minimum=0
//+kubebuilder:validation:Maximum=65535
//+optional
// profilePort allows setting up a Go pprof profiler listening to this port
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add: "Use only for debugging", or something along that line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned face-to-face last week, leaving this port open does not affect performance. It could have some impact just during the profile session, which is at most few seconds.

@jotak
Copy link
Member

jotak commented Sep 19, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 19, 2022
@openshift-ci openshift-ci bot removed the lgtm label Sep 19, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 19, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b04cdad into netobserv:main Sep 21, 2022
@mariomac mariomac deleted the flp-profile branch September 21, 2022 15:34
KalmanMeth pushed a commit to KalmanMeth/network-observability-operator that referenced this pull request Feb 13, 2023
@eranra
Merge pull request netobserv#167 from eranra/fix_dockerfile_2
7af7877 
remove unneeded rm step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotak jotak jotak left review comments

@OlivierCazade OlivierCazade Awaiting requested review from OlivierCazade

@jpinsonneau jpinsonneau Awaiting requested review from jpinsonneau

Assignees

@jotak jotak

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariomac @jotak @openshift-merge-robot