Rename updateConnection -> heartbeat #373
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #373 +/- ##
==========================================
- Coverage 61.91% 60.89% -1.02%
==========================================
Files 91 91
Lines 5873 6281 +408
==========================================
+ Hits 3636 3825 +189
- Misses 2016 2223 +207
- Partials 221 233 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ronensc
force-pushed
the
conntrack-rename-heartbeat
branch
from
15202a5
to
057b5f8
Compare
ronensc
force-pushed
the
conntrack-rename-heartbeat
branch
from
057b5f8
to
0d3c676
Compare
| FlowLog string `yaml:"flowLog" doc:"Flow log"` | ||
| NewConnection string `yaml:"newConnection" doc:"New connection"` | ||
| EndConnection string `yaml:"endConnection" doc:"End connection"` | ||
| Heartbeat string `yaml:"heartbeat" doc:"Heartbeat"` |
There was a problem hiding this comment.
Is Heartbeat too casual? Is HeartbeatConnection preferred?
There was a problem hiding this comment.
What about TickConnection ?
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ronensc
added
the
breaking-change
Fixes #370
This PR should be merge after #357