NETOBSERV-567 Enable connection tracking in NOO #252
Conversation
|
Skipping CI for Draft Pull Request. |
|
Holding this PR as we need console plugin merged at the same time /hold |
Catch read config error
|
/hold for #258 to be merge |
jpinsonneau
force-pushed
the
567
branch
2 times, most recently
from
ac33685
to
e2ab776
Compare
api/v1beta1/flowcollector_types.go
Outdated
| @@ -358,6 +358,16 @@ type FlowCollectorFLP struct { | |||
| // kafkaConsumerBatchSize indicates to the broker the maximum batch size, in bytes, that the consumer will accept. Ignored when not using Kafka. Default: 10MB. | |||
| KafkaConsumerBatchSize int `json:"kafkaConsumerBatchSize"` | |||
|
|
|||
| //+kubebuilder:default:="30s" | |||
| // +optional | |||
| // connection update interval is the duration of time to wait between update reports of a connection | |||
There was a problem hiding this comment.
I agree. There are no min/max. Also the default values were set arbitrarily.
api/v1beta1/flowcollector_types.go
Outdated
| //+kubebuilder:default:={"flowLog"} | ||
| // outputRecordTypes is a list of record types to export from ["flowLog","newConnection","heartbeat","endConnection"] | ||
| // +optional | ||
| OutputRecordTypes *[]string `json:"outputRecordTypes,omitempty"` |
There was a problem hiding this comment.
Providing an empty array here could be an option to say "only export prometheus metrics". I probably need to update a bit the pipeline for that.
IIUC, the proposal is that an empty array will be equivilant to an array with a single value "flowLog" which indicates disabling connection tracking?
|
Addressed feedback on ConnectionHeartbeatInterval renaming + OutputRecordTypes enum |
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: ["quay.io/netobserv/network-observability-operator:8680eee"]. It will expire after two weeks. |
github-actions
bot
removed
the
ok-to-test
|
@msherif1234 splitted commits as requested @Amoghrd also fixed the sample yaml I have updated to flp v0.1.8 and rebased as there was conflicts in go dependencies /ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: ["quay.io/netobserv/network-observability-operator:76733a1"]. It will expire after two weeks. |
|
/lgtm |
|
/qe-approved |
|
/label qe-approved |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpinsonneau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
To allow working / testing https://issues.redhat.com/browse/NETOBSERV-568 I started working on enabling connection tracking in netobserv operator.
The only configurable options are
connectionUpdateIntervalandConnectionEndTimeoutfor consistency in console plugin.